Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hackathon - Town Square - In Review #6359

Merged
merged 31 commits into from
Apr 13, 2020
Merged

Conversation

androolloyd
Copy link
Contributor

@androolloyd androolloyd commented Apr 2, 2020

Description

Integrated Hackathon View

Prize Explorer, Townsquare, Chat, User and Participant explorer v1

Refers/Fixes

#6365
#6363

Testing

@developerfred
Copy link
Contributor

developerfred commented Apr 9, 2020

@PixelantDesign
IMG_4374

agree button don't working
Trust Wallet

@androolloyd androolloyd changed the title Feature/hackathon town square [WIP] Hackathon - Town Square Apr 10, 2020
- new column added, sponsor_profiles, many to many relationship with Profile, limited to only profiles that have a data__type=Organization
the org data returned for the hackathon explorer has been updated to use this new relationship
…-vue.html file,

this revert lets the previous functionality remain for non hackathon bounties until we have finalized more vue changes
Revert "Add prizes header and hero"

This reverts commit aac204b.
…, sponsor tribes widget layout is nearly completed, just the javascript vue work remains
- clean up of some reverted work, more to do,
- missing styles added
- layouts fixed
- mobile css cleaned up
- migrated changes to a new file
- restoring of bountie explorer in progress
- dynamic logos fixed
- all filters now working
- response data is correct, project cards fully functional
Hackathon Dashboard js
 - updated the sidebar bindings so they are working in the new layout
- general clean up
sponsor tribes widget counts, basics of the follow button wired in
@androolloyd androolloyd force-pushed the feature/hackathon-town-square branch from 0b77f73 to 39b5232 Compare April 10, 2020 22:29
@androolloyd
Copy link
Contributor Author

force pushed eslint fix

@androolloyd androolloyd changed the title [WIP] Hackathon - Town Square Hackathon - Town Square - In Review Apr 11, 2020
app/app/urls.py Show resolved Hide resolved
app/bin/easy_install Outdated Show resolved Hide resolved
.Python Outdated Show resolved Hide resolved
app/dashboard/migrations/0092_auto_20200318_0001.py Outdated Show resolved Hide resolved
app/dashboard/migrations/0092_auto_20200318_0001.py Outdated Show resolved Hide resolved
app/dashboard/views.py Outdated Show resolved Hide resolved
app/dashboard/views.py Outdated Show resolved Hide resolved
app/dashboard/views.py Outdated Show resolved Hide resolved
app/dashboard/views.py Outdated Show resolved Hide resolved
app/retail/templates/shared/footer_scripts.html Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Apr 12, 2020

Codecov Report

Merging #6359 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6359   +/-   ##
=======================================
  Coverage   27.45%   27.45%           
=======================================
  Files         287      287           
  Lines       26243    26243           
  Branches     3881     3881           
=======================================
  Hits         7205     7205           
  Misses      18768    18768           
  Partials      270      270           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 071dd02...071dd02. Read the comment docs.

- removing trailing cruft, js and css depdencies snapshotted
- addressing an issue with autogrow, added a flag to disable its execution
- hackathon admins are now added to private project channels alongside bounty funders and team members
Copy link
Member

@thelostone-mc thelostone-mc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see a lot of css code which ideally could have been avoided by using bootstrap classes
code looks alright otherwise !

@androolloyd
Copy link
Contributor Author

I see a lot of css code which ideally could have been avoided by using bootstrap classes
code looks alright otherwise !

Lets make a list and address them in the component refactor.

- serialize the HackathonProject name and looking_members columns to the response
app/assets/v2/js/status.js Outdated Show resolved Hide resolved
@danlipert danlipert merged commit d28196d into master Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants