Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign Gitcoin weekly email template #6227

Closed
wants to merge 9 commits into from

Conversation

iamonuwa
Copy link
Contributor

@iamonuwa iamonuwa commented Mar 14, 2020

Description

Redesign weekly email template

Refers/Fixes

#6208

Testing

https://www.loom.com/share/ebbc26d1bea84a739f1c50b05aa639ed

@iamonuwa
Copy link
Contributor Author

@willsputra @PixelantDesign please I need the sketch or figma link to export assets.

@codecov
Copy link

codecov bot commented Mar 18, 2020

Codecov Report

Merging #6227 into master will decrease coverage by 0.92%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6227      +/-   ##
==========================================
- Coverage   28.13%   27.20%   -0.93%     
==========================================
  Files         281      289       +8     
  Lines       26011    26464     +453     
  Branches     3831     3923      +92     
==========================================
- Hits         7318     7200     -118     
- Misses      18407    18997     +590     
+ Partials      286      267      -19     
Impacted Files Coverage Δ
app/retail/emails.py 22.34% <0.00%> (ø)
app/grants/forms.py 0.00% <0.00%> (-100.00%) ⬇️
app/app/context.py 0.00% <0.00%> (-75.65%) ⬇️
app/retail/helpers.py 28.57% <0.00%> (-42.86%) ⬇️
app/retail/templatetags/matches.py 62.50% <0.00%> (-37.50%) ⬇️
app/search/models.py 64.28% <0.00%> (-23.72%) ⬇️
app/quests/views.py 16.29% <0.00%> (-9.70%) ⬇️
app/search/views.py 30.00% <0.00%> (-6.00%) ⬇️
app/grants/router.py 56.66% <0.00%> (-4.05%) ⬇️
app/grants/admin.py 42.46% <0.00%> (-2.99%) ⬇️
... and 41 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a21b5e5...37fea63. Read the comment docs.

@iamonuwa iamonuwa marked this pull request as ready for review March 18, 2020 09:43
@iamonuwa
Copy link
Contributor Author

Screenshot from 2020-03-18 10-44-25

@owocki
Copy link
Contributor

owocki commented Mar 18, 2020 via email

@iamonuwa
Copy link
Contributor Author

header looks stretched. can we fix that? also we should test how this will look in diff email clients..

I'll fix this

@danlipert
Copy link
Contributor

@iamonuwa is this ready for final review? Also, were you able to test in different clients as @owocki mentioned? If so, please post some screenshots

@iamonuwa
Copy link
Contributor Author

Yes, it's ready. I'll be adding the screenshots now

@iamonuwa
Copy link
Contributor Author

Screenshot from 2020-03-31 13-42-52
Screenshot from 2020-03-31 13-51-23

@PixelantDesign
Copy link
Contributor

looking good! Could we match the padding from this design? https://user-images.githubusercontent.com/19514207/76437182-c1e9a280-63eb-11ea-9321-3f6257d1058f.jpg

Thanks @iamonuwa!

@iamonuwa
Copy link
Contributor Author

Sure, will fix it

@thelostone-mc
Copy link
Member

@iamonuwa yo we ended up getting #6438 in instead as this had a follow up daily up PR which reused stuff from this! Closing this out. ^_^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants