Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update weekly email build #6208

Closed
willsputra opened this issue Mar 11, 2020 · 36 comments · Fixed by #6438
Closed

Update weekly email build #6208

willsputra opened this issue Mar 11, 2020 · 36 comments · Fixed by #6438

Comments

@willsputra
Copy link
Contributor

willsputra commented Mar 11, 2020

@iamonuwa @PixelantDesign

OLD:
weeklyemail-old

NEW:
weeklyemail-new

@iamonuwa
Copy link
Contributor

@owocki
Copy link
Contributor

owocki commented Mar 11, 2020 via email

@willsputra
Copy link
Contributor Author

@owocki will work on it!

@frankchen07
Copy link
Contributor

dope things are looking good! just wanted to link this ticket too since it's dependent on it: #6011

@iamonuwa
Copy link
Contributor

On it guys

@frankchen07
Copy link
Contributor

hi @iamonuwa - nice to see you here again! :)

@iamonuwa
Copy link
Contributor

Thanks @frankchen07

@iamonuwa
Copy link
Contributor

@willsputra figma link for this as well to export assets

@frankchen07
Copy link
Contributor

@iamonuwa - I think this ticket rolls into #6011 - do you agree?

@iamonuwa
Copy link
Contributor

@frankchen07 any design for that? @iamonuwa is available to disrupt ✊

@frankchen07
Copy link
Contributor

oh I thought this ticket was the specific design for that. @willsputra to confirm or deny

@willsputra
Copy link
Contributor Author

@frankchen07 #6011 is for daily ones right? this one's for the existing weekly emails.

@frankchen07
Copy link
Contributor

@willsputra - ah yes you're right. Is it possible to get the design up for the daily too? we can hop on a call and reuse assets from the weekly.

@developerfred
Copy link
Contributor

hey @willsputra do you have this file on figma?

developerfred added a commit to developerfred/web that referenced this issue Mar 22, 2020
developerfred added a commit to developerfred/web that referenced this issue Mar 22, 2020
developerfred added a commit to developerfred/web that referenced this issue Mar 22, 2020
developerfred added a commit to developerfred/web that referenced this issue Mar 22, 2020
*template: email default
* add params: kudos_friday
@willsputra
Copy link
Contributor Author

hey @developerfred are you building the weekly email or daily email?

@gitcoinbot
Copy link
Member

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 0.55 ETH (88.46 USD @ $160.83/ETH) attached to it.

@frankchen07
Copy link
Contributor

@iamonuwa bountied this. If you want to pick it up, please do. If you don't have the bandwidth, no worries someone else will pick it up

@sebastiantf
Copy link
Contributor

@frankchen07 Can I do this?

@frankchen07
Copy link
Contributor

frankchen07 commented Apr 14, 2020

@sebastiantf - sure it's a permissionless bounty, so if you want to start work, submit a work plan, feel free!

hit me or @willsputra if you have any QQs

@gitcoinbot
Copy link
Member

gitcoinbot commented Apr 14, 2020

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

These users each claimed they can complete the work by 1 week, 6 days from now.
Please review their action plans below:

1) sebastiantf has started work.

Update the weekly email design using the new layout

Learn more on the Gitcoin Issue Details page.

@iamonuwa
Copy link
Contributor

I already have a PR for this.

@frankchen07 frankchen07 changed the title Update weekly email design Update weekly email build Apr 14, 2020
@frankchen07
Copy link
Contributor

@iamonuwa - is this for the design or updating the html with the design

@sebastiantf - please hold up on your work, iamonuwa has responded.

@sebastiantf
Copy link
Contributor

Okay @frankchen07

@sebastiantf
Copy link
Contributor

sebastiantf commented Apr 14, 2020

@frankchen07 I've been able to achieve the following. It wouldn't take much time to do the rest.

May I proceed my work? It would be great if you could specify what font you are using so that I can match it.

Update: [deleted image]

@sebastiantf
Copy link
Contributor

sebastiantf commented Apr 15, 2020

@frankchen07 @willsputra I have successfully implemented the new layout as shown below.

I shall create a PR as soon as possible.

final2

@iamonuwa
Copy link
Contributor

@frankchen07 for the new design. @willsputra and @PixelantDesign did

@gitcoinbot
Copy link
Member

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work for 0.55 ETH (86.0 USD @ $156.36/ETH) has been submitted by:

  1. @sebastiantf

@frankchen07 please take a look at the submitted work:


@sebastiantf
Copy link
Contributor

@frankchen07 @willsputra Please look into my PR. It produces the new email template shown in my previous comment.

@frankchen07
Copy link
Contributor

frankchen07 commented Apr 15, 2020

@iamonuwa - got it. I'm mixing up the bounties with the same ticket, so I'll confer with @willsputra to ensure that you get paid out for the design help.

@sebastiantf - thanks for the taking the initiative to upgrade the html. greatly appreciate the quick work and initiative!

would you by any chance be interested in doing the same for #6011? If yes, I'll re-open it and assign you. There might already be some work done on it, but that was before I actually released the design.

@willsputra - let's meet real quick sometime EOW to discuss payouts for iamonuwa and get the deets on that

@sebastiantf
Copy link
Contributor

sebastiantf commented Apr 15, 2020

Yeah sure @frankchen07. I could get on with #6011.

Please do reopen that bounty and assign it to me.

Meanwhile, I could do with some clarifications on this bounty, regarding whether this bounty and my submission for it are valid.

@frankchen07
Copy link
Contributor

@sebastiantf - ok, the bounty should be open again. I reserved it under your GH handle but it doesn't seem to show. Let me know if you have difficulties starting work on it.

@sebastiantf
Copy link
Contributor

@frankchen07 I have started work on #6011 on Gitcoin.

I too couldn't find it in the Gitcoin Issue Explorer. I could only find it when I added the Reserved for me filter.

That may need some looking into.

@sebastiantf
Copy link
Contributor

May I proceed my work? It would be great if you could specify what font you are using so that I can match it.

@frankchen07 @willsputra I haven't changed the font in the new PR. Looking at the new redesign you've posted, the font seems different from what I'm seeing.

Should I change the font? If yes, can you specify what font you've used in the redesign.

@frankchen07
Copy link
Contributor

I'll defer to @willsputra on the font styling.

@sebastiantf
Copy link
Contributor

I'll defer to @willsputra on the font styling.

It's alright @frankchen07 @willsputra. I got it from the figma. No worries.

@gitcoinbot
Copy link
Member

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


The funding of 0.55 ETH (115.96 USD @ $210.83/ETH) attached to this issue has been approved & issued to @sebastiantf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants