Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add .gitattributes and ensure LF for shell files - fixes exit code 2 of Worker in local docker builds on Windows #6175

Merged
merged 1 commit into from
Mar 20, 2020

Conversation

walidmujahid
Copy link
Contributor

@walidmujahid walidmujahid commented Mar 7, 2020

add .gitattributes and ensure LF for shell files - fixes exit code 2 of Worker in local Docker builds on Windows

closes #6136

@codecov
Copy link

codecov bot commented Mar 7, 2020

Codecov Report

Merging #6175 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6175      +/-   ##
==========================================
+ Coverage   28.24%   28.29%   +0.04%     
==========================================
  Files         278      278              
  Lines       25403    25341      -62     
  Branches     3718     3709       -9     
==========================================
- Hits         7175     7169       -6     
+ Misses      17947    17891      -56     
  Partials      281      281
Impacted Files Coverage Δ
app/dashboard/views.py 11.31% <0%> (-0.02%) ⬇️
app/app/urls.py 91.07% <0%> (ø) ⬆️
...perftools/management/commands/create_page_cache.py 0% <0%> (ø) ⬆️
app/avatar/views_3d.py 9.59% <0%> (ø) ⬆️
app/app/context.py 75.64% <0%> (ø) ⬆️
app/grants/views.py 16.46% <0%> (+0.03%) ⬆️
app/app/utils.py 23.75% <0%> (+0.07%) ⬆️
app/townsquare/views.py 10.83% <0%> (+0.09%) ⬆️
app/dashboard/models.py 50.61% <0%> (+0.17%) ⬆️
app/townsquare/models.py 56.65% <0%> (+0.19%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a55de14...684e729. Read the comment docs.

@walidmujahid walidmujahid changed the title add .gitignore and ensure LF for shell files - fixes exit code 2 of Worker add .gitignore and ensure LF for shell files - fixes exit code 2 of Worker in local docker builds Mar 7, 2020
@walidmujahid walidmujahid changed the title add .gitignore and ensure LF for shell files - fixes exit code 2 of Worker in local docker builds add .gitignore and ensure LF for shell files - fixes exit code 2 of Worker in local docker builds on Windows Mar 7, 2020
@walidmujahid walidmujahid changed the title add .gitignore and ensure LF for shell files - fixes exit code 2 of Worker in local docker builds on Windows add .gitattributes and ensure LF for shell files - fixes exit code 2 of Worker in local docker builds on Windows Mar 10, 2020
@walidmujahid walidmujahid force-pushed the master branch 7 times, most recently from 6551f4a to 2c4dd94 Compare March 17, 2020 18:50
@walidmujahid
Copy link
Contributor Author

@owocki @octavioamu This is ready for review.

@thelostone-mc thelostone-mc merged commit 86eb6b2 into gitcoinco:master Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Activity Tags are not working on page refresh - Local Docker
2 participants