feat: editing townsquare comments

[walidmujahid]

Editing a comment is as simple as clicking the edit button on a comment. All other comments of the user will have their edit buttons disabled when editing of a comment is active. Posting new comments for the user will also be disabled while they are editing a comment. If you try to submit an edit with zero characters, it will not go through. An edited comment will show (edited) string next to the timAgo section.

2020-02-30 - Working Demo - Video: https://youtu.be/wibE0emPwBE
2020-02-22 - Video: https://youtu.be/H9tvgp3i0y8

• feat: editing townsquare comments
  • add edit button and handler function
  • handle an EDIT method in api
  • add an 'edited' tag to show the comment was edited
• fix introduced bugs
  • fix issue with empty comment container being disabled after hitting 'Enter'
• code review
• refactor code
• maintainer review

closes #6010

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (master@f1d43c2). Click here to learn what that means.
The diff coverage is 7.14%.

@@            Coverage Diff            @@
##             master    #6023   +/-   ##
=========================================
  Coverage          ?   27.58%           
=========================================
  Files             ?      282           
  Lines             ?    26167           
  Branches          ?     3853           
=========================================
  Hits              ?     7218           
  Misses            ?    18684           
  Partials          ?      265

Impacted Files	Coverage Δ
app/townsquare/views.py	9.88% <0%> (ø)
app/townsquare/models.py	57.79% <100%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1d43c2...54844c8. Read the comment docs.

[frankchen07]

@walidmujahid - this looks pretty dope! thank you for the videos!

1. I didn't see if the trash can (delete comment) functionality works as intended, but I'm sure it does.

edit: just checked the delete comment seems like it's live already! I would want a "are you sure you want to delete this comment" or something but it should be fine right now

2. wanted to make sure that only the user who made the comment can edit it (I think this was obvious but perhaps hard to show in the video).

[walidmujahid]

@frankchen07 Deleting comments is actually feature that @thelostone-mc -if I am not mistaken- had rolled out.

wanted to make sure that only the user who made the comment can edit it (I think this was obvious but perhaps hard to show in the video).

Yes, only the user who posted the comment can edit. I actually tested this with the very useful user impersonation tool, but I did not show it in any video.

I would want a "are you sure you want to delete this comment" or something but it should be fine right now

That is actually a very good idea. I have opened a feature request at #6084 and add it to my list of things to do

[thelostone-mc]

left a bunch of comments regarding indentation plus using const wherever possible

[walidmujahid]

@octavioamu I have worked on the migrations issue. I hope it is better now :-)

[thelostone-mc]

@walidmujahid so you migrations you've deleted , a few would aleady been in live
If we merge this in -> things would get messy
Could you simply readd all the migrations files which you haven't created
And then
ensure there is a single migration file for all your model changes

[walidmujahid]

Yes. Sorry about that. I will do that as soon as possible.

[walidmujahid]

@walidmujahid so you migrations you've deleted , a few would aleady been in live
If we merge this in -> things would get messy
Could you simply readd all the migrations files which you haven't created
And then
ensure there is a single migration file for all your model changes

Resolved @thelostone-mc

[walidmujahid]

@danlipert @thelostone-mc @octavioamu I have updated this with most recent upstream master changes and have recreated the migrations. Manual smoke testing for comment editing functionality passed. Is there anything preventing this from being merged into master?

[thelostone-mc]

@walidmujahid nah it looks good but looks like CI fails due to eslint errors !
It's indentation fix from the looks of it -> if you can get those in, we can try and get this live this week

[thelostone-mc]

@walidmujahid nvm I fixed it up !

[walidmujahid]

@walidmujahid nvm I fixed it up !

Oh, okay. You were quick :-)