Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trending quests in daily email #6080

Merged
merged 5 commits into from
Mar 4, 2020
Merged

Trending quests in daily email #6080

merged 5 commits into from
Mar 4, 2020

Conversation

danlipert
Copy link
Contributor

Description

This PR adds a section to the daily email to add a trending quests section

Refers/Fixes

n/a

Testing

Tested locally

@owocki
Copy link
Contributor

owocki commented Feb 26, 2020

cc @frankchen07 in case its useful for #6011

@frankchen07
Copy link
Contributor

thanks i think it will be

@frankchen07 frankchen07 mentioned this pull request Feb 26, 2020
5 tasks
@codecov
Copy link

codecov bot commented Mar 4, 2020

Codecov Report

Merging #6080 into master will increase coverage by 11.15%.
The diff coverage is 20%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #6080       +/-   ##
===========================================
+ Coverage   17.52%   28.68%   +11.15%     
===========================================
  Files         259      273       +14     
  Lines       23005    29112     +6107     
  Branches     3341     5062     +1721     
===========================================
+ Hits         4032     8350     +4318     
- Misses      18963    20346     +1383     
- Partials       10      416      +406
Impacted Files Coverage Δ
app/app/urls.py 77.41% <ø> (+77.41%) ⬆️
app/marketing/mails.py 13.89% <0%> (+5.26%) ⬆️
app/marketing/views.py 8.53% <17.64%> (+8.53%) ⬆️
app/retail/emails.py 22.86% <50%> (+3.51%) ⬆️
app/inbox/utils.py 37.03% <0%> (-37.97%) ⬇️
app/townsquare/tasks.py 36.17% <0%> (-10.26%) ⬇️
app/townsquare/models.py 66.36% <0%> (-10.11%) ⬇️
app/avatar/views_3d.py 13.7% <0%> (-4.79%) ⬇️
app/dashboard/tasks.py 38.63% <0%> (-4.23%) ⬇️
app/kudos/tasks.py 34.09% <0%> (-3.75%) ⬇️
... and 114 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c0e4b9...fd327f7. Read the comment docs.

@thelostone-mc thelostone-mc merged commit f060057 into master Mar 4, 2020
@sebastiantf sebastiantf mentioned this pull request May 4, 2020
@thelostone-mc thelostone-mc deleted the daily-email-eln branch June 27, 2020 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants