Redesign Daily Email #6471

sebastiantf · 2020-04-19T20:07:55Z

Description

This PR updates the Daily Email template according to the new layout provided here at #6011

Note: This PR is built on top of the commits made in #6438. This branch will update its base branch once #6438 is approved and merged.

Refers/Fixes

Fixes #6011

Screenshots

Gmail Web:

Gmail Mobile:

owocki · 2020-04-20T01:09:52Z

very pumped for this. i think its going to increase DAUs a lot.

putting it on the @gitcoinco/engineers review board

thelostone-mc · 2020-04-21T00:10:12Z

@owocki! will bump this up once we get #6438
Just waiting on @willsputra / @PixelantDesign to check it out and approve it in

PixelantDesign · 2020-04-21T20:19:18Z

looks good!

willsputra · 2020-04-22T12:04:02Z

looks good to me!

frankchen07

LGTM

owocki · 2020-04-22T21:32:51Z

Environment:


Request Method: GET
Request URL: http://localhost:8000/_administration/email/new_bounty_daily

Django Version: 2.2.4
Python Version: 3.6.9
Installed Applications:
['corsheaders',
 'django.contrib.admin',
 'taskapp.celery.CeleryConfig',
 'django_celery_beat',
 'django.contrib.auth',
 'django.contrib.contenttypes',
 'django.contrib.sessions',
 'django.contrib.messages',
 'collectfast',
 'django.contrib.staticfiles',
 'cacheops',
 'storages',
 'social_django',
 'cookielaw',
 'django.contrib.humanize',
 'django.contrib.sitemaps',
 'django.contrib.sites',
 'autotranslate',
 'django_extensions',
 'easy_thumbnails',
 'health_check',
 'health_check.db',
 'health_check.cache',
 'health_check.storage',
 'health_check.contrib.psutil',
 'health_check.contrib.s3boto3_storage',
 'app',
 'avatar',
 'retail',
 'rest_framework',
 'marketing',
 'economy',
 'dashboard',
 'chat',
 'quests',
 'enssubdomain',
 'faucet',
 'tdi',
 'gas',
 'git',
 'healthcheck.apps.HealthcheckConfig',
 'legacy',
 'chartit',
 'email_obfuscator',
 'linkshortener',
 'credits',
 'gitcoinbot',
 'dataviz',
 'impersonate',
 'grants',
 'kudos',
 'django.contrib.postgres',
 'bounty_requests',
 'perftools',
 'revenue',
 'event_ethdenver2019',
 'inbox',
 'feeswapper',
 'search',
 'oauth2_provider',
 'townsquare',
 'compliance',
 'django_nyt.apps.DjangoNytConfig',
 'mptt',
 'sekizai',
 'sorl.thumbnail',
 'wiki.apps.WikiConfig',
 'wiki.plugins.attachments.apps.AttachmentsConfig',
 'wiki.plugins.notifications.apps.NotificationsConfig',
 'wiki.plugins.images.apps.ImagesConfig',
 'wiki.plugins.macros.apps.MacrosConfig',
 'debug_toolbar']
Installed Middleware:
['corsheaders.middleware.CorsMiddleware',
 'django.middleware.security.SecurityMiddleware',
 'django.contrib.sessions.middleware.SessionMiddleware',
 'app.middleware.drop_accept_langauge',
 'django.middleware.locale.LocaleMiddleware',
 'django.middleware.common.CommonMiddleware',
 'django.middleware.csrf.CsrfViewMiddleware',
 'django.contrib.auth.middleware.AuthenticationMiddleware',
 'oauth2_provider.middleware.OAuth2TokenMiddleware',
 'django.contrib.messages.middleware.MessageMiddleware',
 'django.middleware.clickjacking.XFrameOptionsMiddleware',
 'ratelimit.middleware.RatelimitMiddleware',
 'social_django.middleware.SocialAuthExceptionMiddleware',
 'impersonate.middleware.ImpersonateMiddleware']



Traceback:

File "/usr/local/lib/python3.6/dist-packages/django/core/handlers/exception.py" in inner
  34.             response = get_response(request)

File "/usr/local/lib/python3.6/dist-packages/django/core/handlers/base.py" in _get_response
  115.                 response = self.process_exception_by_middleware(e, request)

File "/usr/local/lib/python3.6/dist-packages/django/core/handlers/base.py" in _get_response
  113.                 response = wrapped_callback(request, *callback_args, **callback_kwargs)

File "/usr/local/lib/python3.6/dist-packages/django/contrib/auth/decorators.py" in _wrapped_view
  21.                 return view_func(request, *args, **kwargs)

File "/code/app/marketing/views.py" in new_bounty_daily_preview
  909.     response_html, _ = render_new_bounty('[email protected]', new_bounties, all_bounties, offset=3, trending_quests=quests)

Exception Type: TypeError at /_administration/email/new_bounty_daily
Exception Value: render_new_bounty() got an unexpected keyword argument 'trending_quests'

i get this exception when going to http://localhost:8000/_administration/email/new_bounty_daily

owocki · 2020-04-22T21:37:26Z

./manage.py new_bounties_emailm

how is this email trggered? this command doesnt seemto work and when i hack it to work i get the following

Traceback (most recent call last):
  File "/code/app/marketing/management/commands/new_bounties_email.py", line 82, in handle
    new_bounty_daily(new_bounties, all_bounties, [to_email])
  File "/code/app/marketing/mails.py", line 1152, in new_bounty_daily
    html, text = render_new_bounty(to_email, bounties, old_bounties)
  File "/code/app/retail/emails.py", line 518, in render_new_bounty
    'title': upcoming_grant.title,

i think this PR needs more testing

owocki · 2020-04-22T21:41:29Z

is there an easy way to test this in common mail clients

sebastiantf · 2020-04-23T02:41:41Z

i get this exception when going to http://localhost:8000/_administration/email/new_bounty_daily

@owocki Please try going to http://localhost:8000/_administration/email/new_bounty

This is because I've only modified new_bounty() in emails.py (Line 1296 in the diff) which is executed at /_administration/email/new_bounty, and not new_bounty_daily_preview() in views.py which is executed at /_administration/email/new_bounty_daily

sebastiantf · 2020-04-23T07:17:46Z

I am in need of some help while testing.

While testing the template by sending the email using ./manage.py new_bounties_email, it seems the stylesheets that are imported in shared_template_head.html are not actually getting imported. They get imported fine while testing locally at http://localhost:8000/_administration/email/new_bounty

I had changed the BASE_URL in settings.py from http://localhost:8000/ to http://gitcoin.co/ for testing the email. Is that the right way or am I missing something?

sebastiantf · 2020-04-23T17:15:59Z

I think the external stylesheets that are loaded in shared_template_head.html are somehow not being loaded by premailer

owocki · 2020-04-23T20:53:22Z

might be worth checking how the existing daily email (on master) does this. that loads the stylesheets fine.

owocki · 2020-04-23T20:53:59Z

I had changed the BASE_URL in settings.py from http://localhost:8000/ to http://gitcoin.co/ for testing the email. Is that the right way or am I missing something?

u dont have to do that. at leaset i can test on my local without it

sebastiantf · 2020-04-23T21:04:55Z

u dont have to do that. at leaset i can test on my local without it

Without changing the BASE_URL none of the images are being loaded when I test it via sendgrid.

sebastiantf · 2020-04-23T21:12:30Z

might be worth checking how the existing daily email (on master) does this. that loads the stylesheets fine.

I couldn't find the daily email loading any external stylesheets. I do not think the daily email (or any of the emails) are loading external stylesheets. Please correct me if I'm wrong.

Since I've added the latest activities into the daily email, I've imported external stylesheets which are being used in the Townsquare page to render the activity boxes via the shared_template_head.html:

<link rel="stylesheet" href="{% static "v2/css/bootstrap.min.css" %}" crossorigin="anonymous" data-premailer="ignore">
<link rel="stylesheet" href="{% static "v2/css/lib/typography.css" %}" data-premailer="ignore">
<link rel="stylesheet" href="{% static "v2/css/fontawesome-all.min.css" %}" data-premailer="ignore">
<link rel="stylesheet" href="{% static "v2/css/gitcoin.css" %}" data-premailer="ignore">
<link rel="stylesheet" href="{% static "v2/css/base.css" %}" data-premailer="ignore">
<link rel="stylesheet" href="{% static "v2/css/town_square.css" %}" data-premailer="ignore">
<link rel="stylesheet" href="{% static "v2/css/activity_stream.css" %}" data-premailer="ignore">

These stylesheets are not being correctly loaded, at least not the way they're loaded when visiting http://localhost:8000/_administration/email/new_bounty. I think this has something to do with premailer.

owocki · 2020-04-23T21:54:53Z

premailer takes the linked spreadsheets and applies them inline . thats why they're not being linked externally

…

On Thu, Apr 23, 2020 at 3:12 PM Sebastian T F ***@***.***> wrote: might be worth checking how the existing daily email (on master) does this. that loads the stylesheets fine. I couldn't find the daily email loading any external stylesheets. I do not think the daily email (or any of the emails) are loading external stylesheets. Please correct me if I'm wrong. Since I've added the latest activities into the daily email, I've imported external stylesheets which are being used in the Townsquare page to render the activity boxes via the shared_template_head.html.: These stylesheets are not being correctly loaded, at least not the way they're loaded when visiting .I think this has something to do with premailer. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#6471 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAD5PCNJTWPKFLSOXSYG7X3ROCVM3ANCNFSM4ML52MJQ> .

-- @owocki <http://www.twitter.com/owocki>

_________________________________________ gitcoin is live and has generated over $4.0mm for Open Source Software - see our results <https://gitcoin.co/results>

sebastiantf · 2020-04-24T05:29:20Z

I'm reworking the PR because I'm seeing inconsistencies between the output I receive at http://localhost:8000/_administration/email/new_bounty and the actual email.

thelostone-mc · 2020-04-28T06:33:17Z

@sebastiantf moving this onto a draft PR -> just hit the ready for review button when it's ready

owocki · 2020-04-28T13:00:46Z

@sebastiantf what all are you reworking? whats your ETA?

sebastiantf · 2020-04-28T13:47:23Z

@owocki I figured most of the issues were due to the lack of support from email clients, like not supporting external stylesheets and negative margins. So I have been fixing those and the work is almost complete. Please see the current status:

Gmail Web:

[image moved to original comment]

Gmail for Mobile:

[image moved to original comment]

The only issue left is that the font awesome icons are not being loaded. I shall fix that soon.

I believe I could submit the final PR within 3-4 days. I have to look into the daily email PR too since this PR is based on that and I think most of its issues must be solved by this rework.

Sorry for the delay. I haven't been able to work full time for the last couple of days due to some other engagements.

owocki · 2020-04-28T20:40:49Z

i understand. if you cant get it in today itll probably miss this weeks release... maybe worth getting it firmed up ASAP for inclusion next week

…

On Tue, Apr 28, 2020 at 7:47 AM Sebastian T F ***@***.***> wrote: @owocki <https://github.com/owocki> I figured most of the issues were due to the lack of support from email clients, like not supporting external stylesheets and negative margins. So I have been fixing those and the work is almost complete. Please see the current status: *Gmail Web:* [image: wip_daily_rework_gmail_web] <https://user-images.githubusercontent.com/36922376/80494024-ccec9800-8983-11ea-8ee9-f1faf92866e3.jpg> *Gmail for Mobile:* [image: wip_daily_rework_gmail_android_light] <https://user-images.githubusercontent.com/36922376/80494845-c874af00-8984-11ea-8449-65acd6faab36.jpg> The only issue left is that the font awesome icons are not being loaded. I shall fix that soon. I believe I could submit the final PR within 3-4 days. I have to look into the daily email PR too since this PR is based on that and I think most of its issues must be solved by this rework. Sorry for the delay. I haven't been able to work full time for the last couple of days due to some other engagements. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#6471 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAD5PCLS7BIASB6OAKIDLG3RO3M7ZANCNFSM4ML52MJQ> .

-- @owocki <http://www.twitter.com/owocki>

_________________________________________ gitcoin is live and has generated over $4.0mm for Open Source Software - see our results <https://gitcoin.co/results>

…signature

sebastiantf · 2020-05-26T21:21:44Z

@sebastiantf the email still doesnt match the design in the original post. please make the background color and the header logo match the figma in the OP

https://bits.owocki.com/E0ubkqXR

Done in d0bdd37

sebastiantf requested review from danlipert, octavioamu and thelostone-mc as code owners April 19, 2020 20:07

sebastiantf mentioned this pull request Apr 19, 2020

Update daily email build #6011

Closed

5 tasks

thelostone-mc requested review from frankchen07 and a team and removed request for a team April 21, 2020 00:10

frankchen07 approved these changes Apr 22, 2020

View reviewed changes

thelostone-mc marked this pull request as draft April 28, 2020 06:33

sebastiantf added 23 commits May 27, 2020 02:50

show bounties section only if there are any

f82e503

update new_bounty_daily_preview() to use the new render_new_bounty() …

20fbe3b

…signature

get_specific_activities() in latest_activities()

f2fbe3e

remove bootstrap import

99744a2

some misc styles

b309e75

hide additional data in activitys if not for_email

39ddda1

order grants by weighted_shuffle

0a15906

exception handling for Profile, Notification

86b7d08

fix quest-img margin on large displays

7cc39b1

conditional upcoming_events

0cb046a

all ongoing/first upcoming hackathon

02ae986

always navy footer

dd1bb60

upcoming_grant.next_clr_calc_date or .created_on

ab81775

padding and hr if no upcoming_events

8f4e52c

limit max no. of bounties to 5

d86ce29

update subject line

2751f2c

return single HackathonEvent as List

fd83ff1

remove commented code

165d0a4

remove temp variables

b22a7e7

boilerplate images for missing logos

12d1050

boilerplate image for kudos

2f1ce82

replace refs to external stylesheets with includes

c014741

set email_style = 26 for new header

d0bdd37

sebastiantf force-pushed the redesign-daily-email branch from a7c535d to d0bdd37 Compare May 26, 2020 21:21

remove failing test

6fcb88a

danlipert approved these changes May 27, 2020

View reviewed changes

Merge branch 'master' into redesign-daily-email

feae48b

danlipert merged commit 7942a83 into gitcoinco:master May 27, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Redesign Daily Email #6471

Redesign Daily Email #6471

sebastiantf commented Apr 19, 2020 •

edited

Loading

owocki commented Apr 20, 2020

thelostone-mc commented Apr 21, 2020

PixelantDesign commented Apr 21, 2020

willsputra commented Apr 22, 2020

frankchen07 left a comment

owocki commented Apr 22, 2020

owocki commented Apr 22, 2020

owocki commented Apr 22, 2020

sebastiantf commented Apr 23, 2020 •

edited

Loading

sebastiantf commented Apr 23, 2020 •

edited

Loading

sebastiantf commented Apr 23, 2020

owocki commented Apr 23, 2020

owocki commented Apr 23, 2020

sebastiantf commented Apr 23, 2020 •

edited

Loading

sebastiantf commented Apr 23, 2020 •

edited

Loading

owocki commented Apr 23, 2020 via email

sebastiantf commented Apr 24, 2020

thelostone-mc commented Apr 28, 2020

owocki commented Apr 28, 2020

sebastiantf commented Apr 28, 2020 •

edited

Loading

owocki commented Apr 28, 2020 via email

sebastiantf commented May 26, 2020

Redesign Daily Email #6471

Redesign Daily Email #6471

Conversation

sebastiantf commented Apr 19, 2020 • edited Loading

Description

Refers/Fixes

Screenshots

owocki commented Apr 20, 2020

thelostone-mc commented Apr 21, 2020

PixelantDesign commented Apr 21, 2020

willsputra commented Apr 22, 2020

frankchen07 left a comment

Choose a reason for hiding this comment

owocki commented Apr 22, 2020

owocki commented Apr 22, 2020

owocki commented Apr 22, 2020

sebastiantf commented Apr 23, 2020 • edited Loading

sebastiantf commented Apr 23, 2020 • edited Loading

sebastiantf commented Apr 23, 2020

owocki commented Apr 23, 2020

owocki commented Apr 23, 2020

sebastiantf commented Apr 23, 2020 • edited Loading

sebastiantf commented Apr 23, 2020 • edited Loading

owocki commented Apr 23, 2020 via email

sebastiantf commented Apr 24, 2020

thelostone-mc commented Apr 28, 2020

owocki commented Apr 28, 2020

sebastiantf commented Apr 28, 2020 • edited Loading

owocki commented Apr 28, 2020 via email

sebastiantf commented May 26, 2020

sebastiantf commented Apr 19, 2020 •

edited

Loading

sebastiantf commented Apr 23, 2020 •

edited

Loading

sebastiantf commented Apr 23, 2020 •

edited

Loading

sebastiantf commented Apr 23, 2020 •

edited

Loading

sebastiantf commented Apr 23, 2020 •

edited

Loading

sebastiantf commented Apr 28, 2020 •

edited

Loading