-
-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mini CLR rounds on newsfeed - READY FOR REVIEW #5942
Conversation
Codecov Report
@@ Coverage Diff @@
## stable #5942 +/- ##
==========================================
+ Coverage 28.79% 28.84% +0.05%
==========================================
Files 270 271 +1
Lines 23742 23933 +191
Branches 3454 3487 +33
==========================================
+ Hits 6837 6904 +67
- Misses 16636 16752 +116
- Partials 269 277 +8
Continue to review full report at Codecov.
|
build is failing bc of some rinkeby issue
|
@owocki You need to use a real infura account now with the app id and such https://community.infura.io/t/legacy-key-deprecation/443 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good so far - seems to just need the typical cleanup and also you accidentally mv
d the clr.py file instead of cp
@@ -755,3 +755,6 @@ | |||
RE_MARKET_LIMIT = env.int('RE_MARKET_LIMIT', default=2) | |||
MINUTES_BETWEEN_RE_MARKETING = env.int('MINUTES_BETWEEN_RE_MARKETING', default=60) | |||
|
|||
MINICLR_ADDRESS = env('MINICLR_ADDRESS', default='0x00De4B13153673BCAE2616b67bf822500d325Fc3') | |||
MINICLR_PRIVATE_KEY = env('MINICLR_PRIVATE_KEY', default='0x00De4B13153673BCAE2616b67bf822500d325Fc3') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably worth generating a throwaway keypair here for defaults
sure; is there a .TRAVIS_ENV somewhere we can update? app/travis.env looks like |
61987bc handles rinkeby key |
Description
This is what this looks like:
The bones are done done:
Still gotta put the finishing touches on here:
Refers/Fixes
#5941
Testing
tested locally
should be merged along with #5916