Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mini CLR rounds on newsfeed - READY FOR REVIEW #5942

Merged
merged 20 commits into from
Feb 15, 2020
Merged

mini CLR rounds on newsfeed - READY FOR REVIEW #5942

merged 20 commits into from
Feb 15, 2020

Conversation

owocki
Copy link
Contributor

@owocki owocki commented Feb 5, 2020

Description

This is what this looks like:
Screen Shot 2020-02-11 at 7 18 43 PM

The bones are done done:

  • mechanisms to create /schedule match rounds
  • mechanisms to continually refresh match rankings
  • mechanism to automatically make a CLR payout
  • mechanism to follow users straight on newsfeed

Still gotta put the finishing touches on here:

  • show CLR estimates on newsfeed items (not just leaderboard)
  • make estimates refresh when new tip is made (either ajax or fresh)
  • make tips non alpha
  • a TLDR how it works module (need help from design)
  • what do we do with the follow data? do we highlight it into the various tab types?
  • follow buttons everywhere on newsfeed
  • create Earnings, newsfeed items, email when payout happys. celebrate it!
Refers/Fixes

#5941

Testing

tested locally

should be merged along with #5916

@owocki owocki changed the title POC - mini CLR rounds on newsfeed WIP POC - mini CLR rounds on newsfeed -- DO NOT MERGE Feb 5, 2020
@codecov
Copy link

codecov bot commented Feb 11, 2020

Codecov Report

Merging #5942 into stable will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           stable    #5942      +/-   ##
==========================================
+ Coverage   28.79%   28.84%   +0.05%     
==========================================
  Files         270      271       +1     
  Lines       23742    23933     +191     
  Branches     3454     3487      +33     
==========================================
+ Hits         6837     6904      +67     
- Misses      16636    16752     +116     
- Partials      269      277       +8     
Impacted Files Coverage Δ
app/dashboard/views.py 11.58% <0.00%> (ø) ⬆️
...rketing/management/commands/no_applicants_email.py 0.00% <0.00%> (ø) ⬆️
...eting/management/commands/assemble_leaderboards.py 42.20% <0.00%> (ø) ⬆️
app/townsquare/clr.py 12.64% <0.00%> (ø)
app/dashboard/utils.py 40.81% <0.00%> (+3.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b1d85d...53ea785. Read the comment docs.

@owocki owocki changed the title WIP POC - mini CLR rounds on newsfeed -- DO NOT MERGE mini CLR rounds on newsfeed - READY FOR REVIEW Feb 12, 2020
@owocki
Copy link
Contributor Author

owocki commented Feb 12, 2020

build is failing bc of some rinkeby issue

   
        if http_error_msg:
>           raise HTTPError(http_error_msg, response=self)
E           requests.exceptions.HTTPError: 403 Client Error: Forbidden for url: https://rinkeby.infura.io/

@danlipert
Copy link
Contributor

build is failing bc of some rinkeby issue

   
        if http_error_msg:
>           raise HTTPError(http_error_msg, response=self)
E           requests.exceptions.HTTPError: 403 Client Error: Forbidden for url: https://rinkeby.infura.io/

@owocki You need to use a real infura account now with the app id and such https://community.infura.io/t/legacy-key-deprecation/443

Copy link
Contributor

@danlipert danlipert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good so far - seems to just need the typical cleanup and also you accidentally mvd the clr.py file instead of cp

@@ -755,3 +755,6 @@
RE_MARKET_LIMIT = env.int('RE_MARKET_LIMIT', default=2)
MINUTES_BETWEEN_RE_MARKETING = env.int('MINUTES_BETWEEN_RE_MARKETING', default=60)

MINICLR_ADDRESS = env('MINICLR_ADDRESS', default='0x00De4B13153673BCAE2616b67bf822500d325Fc3')
MINICLR_PRIVATE_KEY = env('MINICLR_PRIVATE_KEY', default='0x00De4B13153673BCAE2616b67bf822500d325Fc3')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably worth generating a throwaway keypair here for defaults

@owocki
Copy link
Contributor Author

owocki commented Feb 12, 2020

@owocki You need to use a real infura account now with the app id and such https://community.infura.io/t/legacy-key-deprecation/443

sure; is there a .TRAVIS_ENV somewhere we can update? app/travis.env looks like

@owocki
Copy link
Contributor Author

owocki commented Feb 13, 2020

61987bc handles rinkeby key

@owocki owocki mentioned this pull request Feb 14, 2020
@owocki owocki merged commit 53ea785 into stable Feb 15, 2020
@thelostone-mc thelostone-mc deleted the kevin/miniclr branch June 27, 2020 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants