Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kevins vision for building up a huge social graph on Gitcoin via tribes #5916

Merged
merged 7 commits into from
Feb 15, 2020

Conversation

owocki
Copy link
Contributor

@owocki owocki commented Jan 31, 2020

  1. Shows the follow button on each and every profile in a standard spot
  2. Shows tribes stats on the follow button
  3. creates a script/post save hooks that auto-create tribes follow relationships when a new earning is created
  4. allows users to opt out of creation of relationships this way.
  5. names the 'join tribe' button to 'follow' which is something that people understand more intituiveily already .

Screen Recording 2020-01-31 at 01 50 PM

@codecov
Copy link

codecov bot commented Jan 31, 2020

Codecov Report

Merging #5916 into stable will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           stable    #5916      +/-   ##
==========================================
+ Coverage    28.8%   28.87%   +0.07%     
==========================================
  Files         271      271              
  Lines       23769    23769              
  Branches     3461     3461              
==========================================
+ Hits         6846     6863      +17     
+ Misses      16656    16631      -25     
- Partials      267      275       +8
Impacted Files Coverage Δ
...eting/management/commands/assemble_leaderboards.py 42.2% <0%> (ø) ⬆️
app/dashboard/views.py 11.58% <0%> (ø) ⬆️
...rketing/management/commands/no_applicants_email.py 0% <0%> (ø) ⬆️
app/dashboard/utils.py 40.81% <0%> (+3.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bd541b...56d36bd. Read the comment docs.

@octavioamu
Copy link
Contributor

I like this, I also suggested the change to "follow" when we built it but I don't remember what were the arguments against that.


class Command(BaseCommand):

help = 'creates earnings records for deploy of https://github.com/gitcoinco/web/pull/5093'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this help need to be fixed

@owocki
Copy link
Contributor Author

owocki commented Feb 7, 2020

@octavioamu talked to alisa about it .. sounds like shes good with th ename change..

also i just made the fixes u requested

@owocki owocki mentioned this pull request Feb 14, 2020
@owocki owocki merged commit 56d36bd into stable Feb 15, 2020
@thelostone-mc thelostone-mc deleted the kevin/tribes branch June 27, 2020 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants