Add metadata card #5889

zoek1 · 2020-01-26T12:38:05Z

Description

parsing and shows metadata preview in the 'post status update' module
when the status update is posted, a card is displayed with the metadata info.

Refers/Fixes

#5880
#5883 previous PR

Testing

codecov · 2020-01-26T23:59:33Z

Codecov Report

Merging #5889 into master will decrease coverage by 0.12%.
The diff coverage is 6.84%.

@@            Coverage Diff             @@
##           master    #5889      +/-   ##
==========================================
- Coverage   28.96%   28.83%   -0.13%     
==========================================
  Files         271      270       -1     
  Lines       23665    23733      +68     
  Branches     3438     3451      +13     
==========================================
- Hits         6854     6843      -11     
- Misses      16538    16621      +83     
+ Partials      273      269       -4

Impacted Files	Coverage Δ
app/retail/views.py	`22.52% <ø> (ø)`	⬆️
app/app/context.py	`68.53% <ø> (ø)`	⬆️
app/app/urls.py	`90.56% <ø> (ø)`	⬆️
app/quests/helpers.py	`20% <0%> (-0.48%)`	⬇️
app/kudos/tasks.py	`34.14% <0%> (-3.7%)`	⬇️
app/dashboard/views.py	`11.6% <0%> (-0.01%)`	⬇️
app/kudos/models.py	`51.71% <0%> (ø)`	⬆️
app/kudos/views.py	`14.83% <0%> (-0.08%)`	⬇️
...quests/management/commands/find_deadbeat_quests.py	`0% <0%> (ø)`	⬆️
app/grants/utils.py	`19.04% <0%> (-0.96%)`	⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46e8e60...d9de8ee. Read the comment docs.

danlipert · 2020-01-27T15:53:07Z

@zoek1 is this ready for review? If not, make sure to use the Draft PR functionality when setting up your PR - thanks!

zoek1 · 2020-01-27T17:15:14Z

@danlipert it's ready! 🤓

Change medium links to redirect to the Gitcoin blog

octavioamu · 2020-02-10T22:48:27Z

testing this on my local, looks really really good.

octavioamu

Just left a comment to add the html also to the new template since the code had changed a little

octavioamu · 2020-02-10T23:33:24Z

app/dashboard/templates/profiles/status_box.html

@@ -29,5 +29,15 @@
      </button>
    </div>
  </div>
+  <div id="thumbnail" class="mt-1 mb-2" style="display: none; top: initial; left: initial; background-color: #FAFAFA">


Can you add this code also to townsquare/templates/index.html ? now as we changed the design I had tested and is the only missing change to this work with the current code.
For my side just that and this is ready to get merge. Good work

thelostone-mc

left a few comments @zoek1 -> otherwise LGTM 🙌
If we can get these changes ready -> we can get it in asap

thelostone-mc · 2020-02-11T04:26:37Z

app/assets/v2/js/status.js

+      let videoId = youtube[1];
+
+      if (embedded_resource !== youtube[0]) {
+        var apiKey = 'AIzaSyDi-EFpC2ntx9PnM_-oiJHk5zCY53KdIf0'; // TODO: add youtube API key to query titles


Could we define this in settings.py and make it such that the user can define it in their .env file
the YOUTUBE_API_KEY would have to be passed from the backend -> which we can use here

thelostone-mc · 2020-02-11T04:26:55Z

app/assets/v2/js/status.js

+      if (embedded_resource !== youtube[0]) {
+        var apiKey = 'AIzaSyDi-EFpC2ntx9PnM_-oiJHk5zCY53KdIf0'; // TODO: add youtube API key to query titles
+
+        let getVideoData = fetchData('https://www.googleapis.com/youtube/v3/videos?key=' + apiKey + '&fields=items(snippet(title))&part=snippet&id=' + videoId);


let -> const

app/assets/v2/js/status.js

thelostone-mc · 2020-02-11T04:28:13Z

app/retail/templates/shared/activity.html

+        <p class="small" style="color: #0056b3">{{ row.metadata.resource.provider }}</p>
+      </div>
+    </div>
+  </div>


^ could we indent this block by 1

thelostone-mc · 2020-02-11T04:28:21Z

app/retail/templates/shared/activity.html

+    <iframe class="col-sm-12" height="315" src="https://www.youtube.com/embed/{{ row.metadata.resource.id }}"
+            frameborder="0" allow="accelerometer; autoplay; encrypted-media; gyroscope; picture-in-picture"
+            allowfullscreen></iframe>
+  </div>


^ could we indent this block by 1

zoek1 · 2020-02-11T08:46:54Z

Great! I just need to sleep and in a couple of hours I'll push the requested changes.

octavioamu · 2020-02-11T13:05:14Z

Thanks @zoek1, lets get this for this week deploy!! going to test giphy integration also

thelostone-mc

chill @zoek1 we'll take care of it
thanks for the awesome work

* fix data model * update active work * fix feedback data * fix icons * uncomment 3box * Add metadata card (#5889) * Embed youtube videos from status * Hide thumbanil by default * Fix lint errors * Substitute youtube URL regex * Add metadata extractor * Display embedded content for youtube and other content * Change medium links to redirect to the gitcoin blog * Update status.js * Update activity.html Co-authored-by: Kevin Owocki <[email protected]> Co-authored-by: Solexplorer <[email protected]> Co-authored-by: Aditya Anand M C <[email protected]> Co-authored-by: Octavio Amuchástegui <[email protected]> * fix up icons * add preview template * youtube api key * 3box under alpha * fix preview grid * meta cards with links * break line * special format for new bounty * makes it so that moderators can hide items on the feed with only one flag * fix travis Co-authored-by: think-in-universe <[email protected]> Co-authored-by: Octavio Amuchástegui <[email protected]> Co-authored-by: Miguel Angel Gordián <[email protected]> Co-authored-by: Kevin Owocki <[email protected]> Co-authored-by: Solexplorer <[email protected]>

zoek1 added 5 commits January 25, 2020 03:30

Embed youtube videos from status

4c63849

Hide thumbanil by default

bba72e5

Fix lint errors

6c0cab3

Substitute youtube URL regex

abf0b88

Add metadata extractor

2a8a139

zoek1 requested review from danlipert, octavioamu and thelostone-mc as code owners January 26, 2020 12:38

zoek1 mentioned this pull request Jan 26, 2020

as a end user I would like to be able to link youtube videos to my status update on gitcoin, so i can share memes and video content #5883

Closed

Display embedded content for youtube and other content

0f0d9d5

zoek1 mentioned this pull request Jan 27, 2020

as a end user I would like to be able to link youtube videos to my status update on gitcoin, so i can share memes and video content #5880

Closed

Merge branch 'master' into feature/metadata-card

46e8e60

This was referenced Feb 5, 2020

as a end user I would like to be able to attach preset memes to my status update on gitcoin, so i can share memes #5898

Merged

as a end user I would like to be able to attach ETH/tokens to my status update on gitcoin, so i can share money #5884

Merged

owocki and others added 3 commits February 6, 2020 10:58

Merge branch 'stable' of github.com:gitcoinco/web

49f5ebc

Change medium links to redirect to the gitcoin blog

1fe6cd2

Merge pull request gitcoinco#5965 from Solexplorer/master

ecc29c3

Change medium links to redirect to the Gitcoin blog

octavioamu added 2 commits February 10, 2020 19:57

Merge branch 'stable'

30791cc

Merge branch 'master' into feature/metadata-card

87d5f21

octavioamu approved these changes Feb 10, 2020

View reviewed changes

thelostone-mc requested changes Feb 11, 2020

View reviewed changes

thelostone-mc added 2 commits February 11, 2020 20:02

Update status.js

3527dcc

Update activity.html

d9de8ee

thelostone-mc approved these changes Feb 11, 2020

View reviewed changes

thelostone-mc changed the base branch from master to stable February 11, 2020 14:34

thelostone-mc merged commit c9bda83 into gitcoinco:stable Feb 11, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add metadata card #5889

Add metadata card #5889

zoek1 commented Jan 26, 2020 •

edited

Loading

codecov bot commented Jan 26, 2020 •

edited

Loading

danlipert commented Jan 27, 2020

zoek1 commented Jan 27, 2020

octavioamu commented Feb 10, 2020

octavioamu left a comment

octavioamu Feb 10, 2020

thelostone-mc left a comment •

edited

Loading

thelostone-mc Feb 11, 2020

thelostone-mc Feb 11, 2020

thelostone-mc Feb 11, 2020

thelostone-mc Feb 11, 2020

zoek1 commented Feb 11, 2020

octavioamu commented Feb 11, 2020

thelostone-mc left a comment

Add metadata card #5889

Add metadata card #5889

Conversation

zoek1 commented Jan 26, 2020 • edited Loading

Description

Refers/Fixes

Testing

codecov bot commented Jan 26, 2020 • edited Loading

Codecov Report

danlipert commented Jan 27, 2020

zoek1 commented Jan 27, 2020

octavioamu commented Feb 10, 2020

octavioamu left a comment

Choose a reason for hiding this comment

octavioamu Feb 10, 2020

Choose a reason for hiding this comment

thelostone-mc left a comment • edited Loading

Choose a reason for hiding this comment

thelostone-mc Feb 11, 2020

Choose a reason for hiding this comment

thelostone-mc Feb 11, 2020

Choose a reason for hiding this comment

thelostone-mc Feb 11, 2020

Choose a reason for hiding this comment

thelostone-mc Feb 11, 2020

Choose a reason for hiding this comment

zoek1 commented Feb 11, 2020

octavioamu commented Feb 11, 2020

thelostone-mc left a comment

Choose a reason for hiding this comment

zoek1 commented Jan 26, 2020 •

edited

Loading

codecov bot commented Jan 26, 2020 •

edited

Loading

thelostone-mc left a comment •

edited

Loading