Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update active bounties logic #5785

Merged
merged 1 commit into from
Jan 15, 2020

Conversation

thelostone-mc
Copy link
Member

@thelostone-mc thelostone-mc commented Jan 13, 2020

Description

Use the new bounty_state defined in models.py as opposed to idx_status

closes #3782

@codecov
Copy link

codecov bot commented Jan 13, 2020

Codecov Report

Merging #5785 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5785   +/-   ##
=======================================
  Coverage   29.71%   29.71%           
=======================================
  Files         257      257           
  Lines       21935    21935           
  Branches     3189     3189           
=======================================
  Hits         6518     6518           
+ Misses      15140    15137    -3     
- Partials      277      280    +3
Impacted Files Coverage Δ
app/dashboard/views.py 11.59% <0%> (ø) ⬆️
app/dashboard/models.py 56.31% <0%> (ø) ⬆️
...rketing/management/commands/no_applicants_email.py 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4f3a69...6b31ed5. Read the comment docs.

@octavioamu octavioamu merged commit 02e7b92 into gitcoinco:master Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

As a Gitcoin operator, the way we are counting bounty limits is inaccurate.
3 participants