Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update email text for stale funder + schwag #5699

Merged
merged 1 commit into from
Jan 6, 2020
Merged

chore: update email text for stale funder + schwag #5699

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions app/retail/emails.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,7 +385,7 @@ def render_bounty_feedback(bounty, persona='submitter', previous_bounties=[]):

alisa / frank (gitcoin product team)

PS - we've got some new gitcoin schwag on order. send me your mailing address and your t shirt size and i'll ship you some.
PS - we've got some new gitcoin schwag on order. if interested, let us know and we can send you a code to order some :)

"""
elif bounty.status == 'cancelled':
Expand All @@ -406,7 +406,7 @@ def render_bounty_feedback(bounty, persona='submitter', previous_bounties=[]):

alisa / frank (gitcoin product team)

PS - we've got some new gitcoin schwag on order. send me your mailing address and your t shirt size and i'll ship you some.
PS - we've got some new gitcoin schwag on order. if interested, let us know and we can send you a code to order some :)

"""
else:
Expand Down Expand Up @@ -443,7 +443,7 @@ def render_admin_contact_funder(bounty, text, from_user):
return response_html, response_txt


def render_funder_stale(github_username, days=30, time_as_str='about a month'):
def render_funder_stale(github_username, days=60, time_as_str='a couple months'):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while i think this is the right code change -- @frankchen07 also mentioned in chat that emails are happening sometimes even more regularly than 30 days, so i'm not sure if this will solve the root problem 🤔

still worth making the change to 60 days IMO

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will keep an eye out for that 🙌

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's more that funders who are funding issues are still getting the emails - they usually respond with "I think something's wrong with your system, I've funded a couple issues."

Perhaps it is just a time elapsed issue, since if I funded something 30 days back and just am waiting on work, I might get sent the funder email.

"""Render the stale funder email template.

Args:
Expand All @@ -459,14 +459,15 @@ def render_funder_stale(github_username, days=30, time_as_str='about a month'):
response_txt = f"""
hi {github_username},

alisa and frank from Gitcoin here (CC scott and vivek too) — i see you haven't funded an issue in {time_as_str}. in the spirit of making Gitcoin better + checking in:
alisa and frank from Gitcoin here (CC scott and vivek too) — i see you haven't funded an issue in {time_as_str}.
in the spirit of making Gitcoin better + checking in:

- has anything been slipping on your issue board which might be bounty worthy?
- have any issues which might be bounty worthy or projects you're hoping to build?
- do you have any feedback for Gitcoin Core on how we might improve the product to fit your needs?
- are you interested in joining one of <a href="https://gitcoin.co/hackathon-list/">our upcoming hackathons?</a> it's possible
we could do so at a discount, as you're a current funder on the platform

our idea is that gitcoin should be a place you come when priorities stretch long, and you need an extra set of capable hands. curious if this fits what you're looking for these days.

appreciate you being a part of the community and let me know if you'd like some Gitcoin schwag — just send over a mailing address and a t-shirt size and it'll come your way.
appreciate you being a part of the community + let us know if you'd like some Gitcoin schwag, we can send a link your way to order some :)

~ alisa / frank (gitcoin product team)

Expand Down
2 changes: 1 addition & 1 deletion scripts/crontab
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/us
30 1 * * * cd gitcoin/coin; bash scripts/run_management_command_if_not_already_running.bash sync_github >> /var/log/gitcoin/sync_github.log 2>&1
*/15 * * * * cd gitcoin/coin; bash scripts/run_management_command_if_not_already_running.bash get_notifications >> /var/log/gitcoin/get_notifications.log 2>&1
15 10 * * * cd gitcoin/coin; bash scripts/run_management_command_if_not_already_running.bash bounty_feedback_email >> /var/log/gitcoin/bounty_feedback_email.log 2>&1
15 10 * * * cd gitcoin/coin; bash scripts/run_management_command_if_not_already_running.bash funder_stale_email 30 >> /var/log/gitcoin/funder_stale_email.log 2>&1
15 10 * * * cd gitcoin/coin; bash scripts/run_management_command_if_not_already_running.bash funder_stale_email 60 >> /var/log/gitcoin/funder_stale_email.log 2>&1
15 11 * * * cd gitcoin/coin; bash scripts/run_management_command_if_not_already_running.bash new_bounties_email >> /var/log/gitcoin/new_bounties_email.log 2>&1
15 10 * * * cd gitcoin/coin; bash scripts/run_management_command_if_not_already_running.bash campaign_email >> /var/log/gitcoin/campaign_email.log 2>&1
15 10 * * * cd gitcoin/coin; bash scripts/run_management_command_if_not_already_running.bash send_unread_notification_emails_roundup >> /var/log/gitcoin/send_unread_notification_emails_roundup.log 2>&1
Expand Down