chore: update email text for stale funder + schwag #5699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
thelostone-mc
changed the title
vs77bb
approved these changes
Jan 3, 2020
| @@ -443,7 +443,7 @@ def render_admin_contact_funder(bounty, text, from_user): | |||
| return response_html, response_txt | |||
|
|
|||
|
|
|||
| def render_funder_stale(github_username, days=30, time_as_str='about a month'): | |||
| def render_funder_stale(github_username, days=60, time_as_str='a couple months'): | |||
There was a problem hiding this comment.
while i think this is the right code change -- @frankchen07 also mentioned in chat that emails are happening sometimes even more regularly than 30 days, so i'm not sure if this will solve the root problem 🤔
still worth making the change to 60 days IMO
There was a problem hiding this comment.
will keep an eye out for that 🙌
There was a problem hiding this comment.
I think it's more that funders who are funding issues are still getting the emails - they usually respond with "I think something's wrong with your system, I've funded a couple issues."
Perhaps it is just a time elapsed issue, since if I funded something 30 days back and just am waiting on work, I might get sent the funder email.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
duplicate of #5685