Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tip error and kill bounty #5682

Closed
wants to merge 1 commit into from
Closed

Conversation

zoek1
Copy link
Contributor

@zoek1 zoek1 commented Dec 24, 2019

Description
  1. Fix error on sending tips due to encoding error, no related to opera:
    image
  2. Fix kill bounty error:
    image
Refers/Fixes

#5466

Testing

@codecov
Copy link

codecov bot commented Dec 24, 2019

Codecov Report

Merging #5682 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5682      +/-   ##
==========================================
+ Coverage   30.09%   30.12%   +0.02%     
==========================================
  Files         249      249              
  Lines       21448    21447       -1     
  Branches     3110     3110              
==========================================
+ Hits         6454     6460       +6     
+ Misses      14718    14711       -7     
  Partials      276      276
Impacted Files Coverage Δ
app/git/utils.py 39.76% <ø> (+0.09%) ⬆️
app/dashboard/embed.py 31.6% <0%> (+3.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff1a890...9f97f22. Read the comment docs.

thelostone-mc added a commit to thelostone-mc/web that referenced this pull request Feb 4, 2020
@thelostone-mc
Copy link
Member

Hey @zoek1 ! So the conflicts have come in cause the files have been renamed split
I've ported over you code here #5936 and closing this out 🙌

thelostone-mc added a commit that referenced this pull request Feb 4, 2020
duplicate: Fix tip error and kill bounty #5682
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants