Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do a sweep of site on opera web3 and note (and fix) what pages do not work #5466

Closed
owocki opened this issue Nov 7, 2019 · 40 comments · Fixed by #5503
Closed

do a sweep of site on opera web3 and note (and fix) what pages do not work #5466

owocki opened this issue Nov 7, 2019 · 40 comments · Fixed by #5503
Assignees
@owocki

Comments

@owocki
Copy link
Contributor

owocki commented Nov 7, 2019 •
edited
Loading

from our friend @yorkerhodes :

Using opera, there Still seems to be an issue on Funding here:

unnamed

but it works on other pages!

the scope of this bounty is to

  1. install opera + opera crypto wallet
  2. figure out what pages are working + what are not
  3. submit a patch for those who arent working
  4. this bounty should not take mor ethan 1 week. it should have an accepted PR by 11/14

page list to sweep

  1. kudos send
  2. kudos receive
  3. kudos airdrop
  4. tip send
  5. tip receive
  6. bounty new/increase/payout/accept
  7. grant fund, grant create, grant cancel

we can do this bounty one of two ways: i will give a (reputable) bounty hunter some ETH to test in prodl.... or you can clone the repo and test locally..
@gitcoinbot
Copy link
Member

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This issue now has a funding of 0.8 ETH (149.06 USD @ $186.33/ETH) attached to it.

@zoek1
Copy link
Contributor

zoek1 commented Nov 8, 2019

hey @owocki, i can start working on this. I have full setup to test this and start to work. I can't apply at gitcoin because i just waiting this bounty being merge. But in the meantime i can start working on this. what do you think?

@gitcoinbot
Copy link
Member

gitcoinbot commented Nov 8, 2019 •
edited
Loading

Issue Status: 1. Open 2. Cancelled

Work has been started.

These users each claimed they can complete the work by 1 month, 3 weeks ago.
Please review their action plans below:

1) theperfectpunk has applied to start work (Funders only: approve worker | reject worker).

I can clone the github repo and test it on opera windows, linux and mac
2) zoek1 has been approved to start work.

I've a ready enviroment to test what pages are working and what are not, after that i'll submit a patch for those who arent working.

Learn more on the Gitcoin Issue Details page.

@owocki
Copy link
Contributor Author

owocki commented Nov 8, 2019

@zoek1 sure i just upped your work limit so u can apply

@owocki
Copy link
Contributor Author

owocki commented Nov 8, 2019

@theperfectpunk @Jorropo - gitcoin shows your reliability ratings to be a bit low... do u think thats fair? (asking as someone who build that reliability algorithm a while back.. i want feedback from someone whos actually affected by it!)

@theperfectpunk
Copy link

@owocki I don't think that's fair as I have completed only one other bounty on gitcoin and that too on time so that should give me a positive reliability. But if the number of bounty previously completed alone increases the reliability and you start from zero reliability, then it is fair.

@owocki
Copy link
Contributor Author

owocki commented Nov 9, 2019

thanks for the feedback.. we might need to smooth the curve from 'unproven' to actually joining the reliability rating system :)

@owocki
Copy link
Contributor Author

owocki commented Nov 11, 2019 via email

@owocki
Copy link
Contributor Author

owocki commented Nov 11, 2019

@zoek1 still want to work on this?

@zoek1
Copy link
Contributor

zoek1 commented Nov 12, 2019

Sure, I'll start in the morning after take a rest for this night after the Web3 World Hackathon 😅

@zoek1
Copy link
Contributor

zoek1 commented Nov 13, 2019

Update: Fixing some error i found one problem, the code depends on web3.eth but at opera such attribute is set to null. What opera says about this:

A common issue we see in Dapps is that their developers assume that a Web 3 browser == MetaMask and that they will magically have access to a Web3.js library, injected inside the page on their behalf.
We see this implicit dependency & injection as a bad practice that needs to disappear for the ecosystem to move forward. Developers should import the web3 convenience library of their choice and build their Dapp on top of that, just as they do for other Javascript libraries.
Opera exposes a Web3 Provider (window.web3.currentProvider) which you need to instantiate your own web3 object from.

So i my next step is add the js library and add conditionally the web3 object using the web3.currentProvider provide by opera. After that, i'll check is this patch work well with the others functionality.

@owocki
Copy link
Contributor Author

owocki commented Nov 13, 2019

the web3 js library should already be included on each page

@zoek1
Copy link
Contributor

zoek1 commented Nov 13, 2019

Ok, i missed that. 😅 Then i'll take care of that and start from there.

owocki added a commit that referenced this issue Nov 15, 2019
@owocki
non metamask support #5466
2f51829
@owocki
Copy link
Contributor Author

owocki commented Nov 15, 2019

2f51829 should help with the fund/submit/contribute pages!

@zoek1 zoek1 mentioned this issue Nov 15, 2019
Closed
@zoek1
Copy link
Contributor

zoek1 commented Nov 15, 2019 •
edited
Loading

Sure, it helps thanks! Also i pushed a PR that cover Kudos, Tips and Bounties actions. The grants have a strange behavior, so i need to go deep.

DeepinScreenshot_20191115032546
DeepinScreenshot_20191115032729

@octavioamu octavioamu mentioned this issue Nov 15, 2019
Merged
@owocki
Copy link
Contributor Author

owocki commented Nov 16, 2019

#5503 (review)

@zoek1 zoek1 mentioned this issue Nov 17, 2019
Closed
@zoek1
Copy link
Contributor

zoek1 commented Nov 18, 2019

@owocki can we split this, create a grant at opera its more difficult that the previous elements, specifically create grant. Two problems exists: The transaction is generated but never display notification at the wallet to deploy the contract and sometimes crash the browser on deploying the contract.
I'll open a new PR specifically for grants to don't block the other elements. funds and cancel grant are easy but i woul like have the complete flow for grant at one place.

@owocki
Copy link
Contributor Author

owocki commented Nov 18, 2019 via email

@zoek1
Copy link
Contributor

zoek1 commented Nov 21, 2019

@thelostone-mc could this be reopen this issue, the grant isn't working and #5500 is complementary to this issue and it's still no merged. Fixes cancel issue on opera and add conditionals when no metamask is installed.

@gitcoinbot
Copy link
Member

@zoek1 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

3 similar comments
@gitcoinbot
Copy link
Member

@zoek1 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link
Member

@zoek1 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link
Member

@zoek1 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@owocki
Copy link
Contributor Author

owocki commented Dec 3, 2019

hey guys what is the recommended path here? does @zoek1 's PR jibe well with @octavioamu 's ?

@octavioamu
Copy link
Contributor

I don't see the propose of merging @zoek1 since the problem is solved on production already. But @zoek1 feel free to tell is if something is missing on production.

@owocki
Copy link
Contributor Author

owocki commented Dec 3, 2019 via email

@octavioamu
Copy link
Contributor

Actually I believe the missing part is grants, since is totally separated code from the other parts. And of course test everything just to check if we didn't miss anything.

@zoek1
Copy link
Contributor

zoek1 commented Dec 5, 2019

I'll review to see if there are some pages with errors. I'll publish one update in a couple hours

@gitcoinbot
Copy link
Member

@zoek1 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

1 similar comment
@gitcoinbot
Copy link
Member

@zoek1 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link
Member

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

@zoek1 due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

1 similar comment
@gitcoinbot
Copy link
Member

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

@zoek1 due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@owocki
Copy link
Contributor Author

owocki commented Dec 12, 2019 via email

@zoek1
Copy link
Contributor

zoek1 commented Dec 13, 2019

Yes, please @owocki! Just give me the weekend and I'll publish the status and what not works on opera, I already detected some pages but I need to take time to seat and rank them in priority order and complexity. Also with changes to fix some of them. 😅

@gitcoinbot
Copy link
Member

@zoek1 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

1 similar comment
@gitcoinbot
Copy link
Member

@zoek1 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@zoek1
Copy link
Contributor

zoek1 commented Dec 19, 2019

Just reporting I'm free. I'm ready to continue on this! 💪

@owocki
Copy link
Contributor Author

owocki commented Dec 19, 2019 via email

@zoek1 zoek1 mentioned this issue Dec 24, 2019
Closed
@zoek1
Copy link
Contributor

zoek1 commented Dec 24, 2019

The current status of gitcoin main actions on opera:
Bounties

Tip

  • ✔️ Send tip
  • ✅ Receive Tip

Kudos

  • ✔️ Create kudos
  • ✔️ Send kudos
  • ✅ Receive kudos

Grant

  • ❎ Create grant
    When the contract is being deployed, crash the browser
  • ✔️ Fund grant
  • ❎ Cancel Funding
  • ✔️ Cancel grant

My next steps are debug where exactly crash the browser and see how to fix the create grant process.
@owocki

@gitcoinbot
Copy link
Member

Issue Status: 1. Open 2. Cancelled

The funding of 0.8 ETH (136.52 USD @ $170.65/ETH) attached to this issue has been cancelled by the bounty submitter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@owocki owocki

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Opera bounties gitcoinco/web
5 participants
@owocki @zoek1 @octavioamu @theperfectpunk @gitcoinbot