Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: /2 crosschain etc integration #5627

Merged
merged 6 commits into from
Jan 10, 2020

Conversation

thelostone-mc
Copy link
Member

@thelostone-mc thelostone-mc commented Dec 12, 2019

Description
  • renamed TODO to ETC Todo to make todo easier to spot
Bounty Details
  • remove promote bounty + contribute page
  • ETH/ERC20 directs to increase bounty page directly
  • text updated on increase button to show crowdfund / increase
  • update view to ensure data specific to ETH+ERC20 doesn't show up in ERC
    bounties
Edit Bounty Details
  • updated bounty details to show featured section only for ETH/ERC which aren't featured
  • fixed broken invite by skill button
  • added ability to update bounty amount for ETC bounties
Bounty Cancellation
  • update comments for bounty cancellation
  • split code for bounty cancellation for ETH and other tokens
  • introduced new api endpoint for bounty cancellation
  • rename kill_bounty.js -> cancel_bounty/index.js
  • rename kill.html -> cancel.html
  • add @login_required decorator to cancellation
Bounty Fulfillment
  • cleaned + refactored fulfill UI + removed un-needed files
  • add @login_required decorator to fulfillment
  • split code for bounty fulfillment for ETH and other tokens
  • introduced new api endpoint for bounty fulfillment
  • rename fulfill_bounty.js -> fulfill_bounty/index.js
Ref

feat: /1 #5600

image

Screenshot 2019-12-26 at 5 01 06 PM

Screenshot 2019-12-26 at 5 01 18 PM

Screenshot 2019-12-26 at 10 21 46 PM

@codecov
Copy link

codecov bot commented Dec 12, 2019

Codecov Report

Merging #5627 into master will decrease coverage by 0.21%.
The diff coverage is 21.68%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5627      +/-   ##
==========================================
- Coverage   29.96%   29.74%   -0.22%     
==========================================
  Files         249      257       +8     
  Lines       21571    21932     +361     
  Branches     3128     3188      +60     
==========================================
+ Hits         6463     6524      +61     
- Misses      14832    15131     +299     
- Partials      276      277       +1
Impacted Files Coverage Δ
app/app/thumbnail_processors.py 33.33% <ø> (ø) ⬆️
app/git/apps.py 0% <ø> (ø) ⬆️
app/dashboard/tip_views.py 17.41% <ø> (ø) ⬆️
...ashboard/management/commands/setup_grants_clr_3.py 0% <ø> (ø) ⬆️
app/dashboard/management/commands/calc_profile.py 0% <ø> (ø) ⬆️
.../dashboard/management/commands/migrate_profiles.py 0% <ø> (ø) ⬆️
app/grants/templatetags/grants_extra.py 100% <ø> (ø) ⬆️
...rants/management/commands/grant_vitalik_shuffle.py 0% <ø> (ø) ⬆️
app/economy/models.py 58.25% <ø> (ø) ⬆️
app/dashboard/notifications.py 16.47% <ø> (ø) ⬆️
... and 109 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a516408...045bfa1. Read the comment docs.

@thelostone-mc thelostone-mc force-pushed the purge branch 2 times, most recently from d59ba60 to 6ad6ee6 Compare December 19, 2019 14:37
- ETH/ERC20 directs to increase bounty page directly
- text updated on increase button to show crowdfund / increase
- update comments for bounty cancellation
- split code for bounty cancellation for ETH and other tokens
- introduced new api endpoint for bounty cancellation
- rename kill_bounty.js -> cancel_bounty/index.js
- rename kill.html -> cancel.html
@thelostone-mc thelostone-mc force-pushed the purge branch 2 times, most recently from 50f8e56 to 1780420 Compare December 25, 2019 17:38
- add @login_required decorator to fulfillment
- split code for bounty fulfillment for ETH and other tokens
- introduced new api endpoint for bounty fulfillment
- rename fulfill_bounty.js -> fulfill_bounty/index.js
- fixed broken invite by skill button
- update bounty amount for ETC bounties
@@ -112,7 +260,7 @@ $(document).ready(function() {
ignore: '',
messages: {
select2Start: {
required: 'Please select the right keywords.'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol

Copy link
Contributor

@octavioamu octavioamu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work @thelostone-mc

@thelostone-mc thelostone-mc merged commit fe97b96 into gitcoinco:master Jan 10, 2020
@thelostone-mc thelostone-mc deleted the purge branch January 16, 2020 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants