feat: /1 crosschain etc integration #5600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thelostone-mc
force-pushed
the
sync_etc
branch
from
de1ba26 to
9deb0b4
Compare
Codecov Report
@@ Coverage Diff @@
## master #5600 +/- ##
==========================================
- Coverage 30.19% 30.03% -0.17%
==========================================
Files 248 248
Lines 21215 21348 +133
Branches 3075 3095 +20
==========================================
+ Hits 6406 6411 +5
- Misses 14533 14658 +125
- Partials 276 279 +3
Continue to review full report at Codecov.
|
thelostone-mc
force-pushed
the
sync_etc
branch
from
9deb0b4 to
b0a83c7
Compare
thelostone-mc
commented
Dec 5, 2019
thelostone-mc
force-pushed
the
sync_etc
branch
from
b0a83c7 to
01394ad
Compare
thelostone-mc
changed the title
danlipert
approved these changes
Dec 11, 2019
| @@ -62,8 +62,8 @@ | |||
| # oauth2 provider | |||
| url('^o/', include('oauth2_provider.urls', namespace='oauth2_provider')), | |||
| path('jsi18n/', JavaScriptCatalog.as_view(), name='javascript-catalog'), | |||
| # create bounty | |||
| url(r'^create?', dashboard.views.new_bounty, name='create_bounty'), # TODO: Remove | |||
There was a problem hiding this comment.
This definitely isn't used anywhere? or by some weird 3rd party integration that we forgot about or something?
There was a problem hiding this comment.
Yeah ! This was introduced as a means to have multiple ways to access the same way !
the 3rd part were with -> /new OR /fund (cause one of those were added cause of that )
I don't know if that 3rd part integration even exists (separate story all together )
octavioamu
reviewed
Dec 11, 2019
octavioamu
reviewed
Dec 11, 2019
thelostone-mc
force-pushed
the
sync_etc
branch
from
ae9d49f to
fd93a4e
Compare
thelostone-mc
changed the title
- introduce new endpoint for ETH + EC20 bounties - splits code for ETH and ETC bounty creation to ensure ETH bounties go normal flow while ETC bounties hit new endpoint - sync_etc url + create API are restricted to admin - update bounty details condition to ensure for ETH bounties actions needs user to be logged in and have the right address
thelostone-mc
force-pushed
the
sync_etc
branch
from
fd93a4e to
e28547c
Compare
octavioamu
approved these changes
Dec 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
bounties go normal flow while ETC bounties hit new endpoint
actions needs user to be logged in and have the right address
Pending
/createendpoint/createendpoint/createendpointTesting