Unify navbar template #549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owocki
approved these changes
Mar 6, 2018
|
|
||
|
|
||
| @register.filter | ||
| def is_in_list(value, input_list): |
There was a problem hiding this comment.
oooh ive never done this in django before.. cool!
Codecov Report
@@ Coverage Diff @@
## master #549 +/- ##
=======================================
Coverage 29.04% 29.04%
=======================================
Files 86 86
Lines 4555 4555
Branches 547 547
=======================================
Hits 1323 1323
Misses 3185 3185
Partials 47 47Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The goal of this PR is to simplify the navbar handling by removing
nav_internal.htmland handle all related navbar logic innav.htmlChecklist
Affected core subsystem(s)
ui, nav
Testing
Tested all changes locally on all views.
Refers/Fixes
Fixes: #548