feat: account for single contribution for grant in clr #5277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thelostone-mc
requested review from
danlipert and
octavioamu
as code owners
Codecov Report
@@ Coverage Diff @@
## master #5277 +/- ##
==========================================
- Coverage 29.89% 29.89% -0.01%
==========================================
Files 230 230
Lines 18997 19000 +3
Branches 2709 2710 +1
==========================================
Hits 5680 5680
- Misses 13080 13083 +3
Partials 237 237
Continue to review full report at Codecov.
|
danlipert
reviewed
Sep 30, 2019
| @@ -64,6 +64,10 @@ def generate_grant_pair(grant): | |||
| else: | |||
| unique_contributions[profile] = amount | |||
|
|
|||
| if len(unique_contributions) == 1: | |||
| profile = next(iter(unique_contributions)) | |||
There was a problem hiding this comment.
nice! some mystical python here :)
danlipert
approved these changes
Sep 30, 2019
octavioamu
approved these changes
Oct 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pairs the contributor with itself and ensures grants get matching clr even if it has one contributor
If grant has only 1 contributor.
Assume with
contributor_profile : 1who contributed5 DAI:1 DAI(I'm assuming this is the lowest possible contribution )
1&_1with contributions5 DAIand1 DAIIf a new profile contributes,
the pesudo contributor_profile's (
_1) contibution (1 DAI) is ignored and algorithm works as usualRefers/Fixes
Fixes: #5223
Testing
https://share.vidyard.com/watch/rTqnXvuiRuswAnbvK91GbR?