Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gitcoin Grants CLR Round 3 v2 Improvements #5223

Closed
3 tasks done
frankchen07 opened this issue Sep 19, 2019 · 1 comment · Fixed by #5277
Closed
3 tasks done

Gitcoin Grants CLR Round 3 v2 Improvements #5223

frankchen07 opened this issue Sep 19, 2019 · 1 comment · Fixed by #5277
Assignees

Comments

@frankchen07
Copy link
Contributor

frankchen07 commented Sep 19, 2019

User Story

Gitcoin Grants CLR Round 3 v2 Improvements

Why Is this Needed

Product experiment asks from Vitalik, v2 improvements post v1 launch.

Description

  1. CLR live pop-up design update (@willsputra / @PixelantDesign stated that using a navy colored background would be better)

Screen Shot 2019-09-19 at 11 25 35 AM

Is it possible to make it pop up only when there's a number entered in amount field?

  1. How are we calculating non-pairs? Currently it makes sense that if a grant only has one contribution, it would be paired by itself, resulting in a CLR contribution that is either equal to the contribution itself or the threshold. (@thelostone-mc to check). This will also fix the 0 DAI matching for those grants that don't have a matching CLR pair yet.

  2. Add phantom funding to the CLR estimate (@thelostone-mc & @danlipert)

  3. Ensure that dropped txns make its way into the formula. As of 2019-09-24, contribution IDs (1207, 1208, 1209, 1210, 1211, 1212, 1213) were dropped and replaced due to gas issues

Current Behavior

v1 grants clr

Expected Behavior

add v2 improvements

Definition of Done

  • update design
  • ensure grant non-pairs calculation makes sense
  • add phantom funding to the CLR estimate
@thelostone-mc
Copy link
Member

thelostone-mc commented Sep 26, 2019

made it a lil cleaner like in the landing page
(PR #5264)

Screenshot 2019-09-26 at 8 54 59 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants