Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add email capture to landing #4847

Merged
merged 2 commits into from
Jul 24, 2019
Merged

feat: add email capture to landing #4847

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8adf712
add email capture to landing
thelostone-mc Jul 23, 2019
37acecd
Merge branch 'master' into mail
danlipert Jul 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions app/assets/v2/css/home.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,10 @@
color: #0D0764;
}

.homepage .newsletter {
border-top: none;
}

.watch a {
color: #0D0764;
}
Expand Down
3 changes: 3 additions & 0 deletions app/assets/v2/css/newsletter.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,9 @@
border: 1px solid #eee;
border-top-left-radius: 5px;
border-bottom-left-radius: 5px;
width: 18rem;
text-align: center;
outline: none;
}

.newsletter .addon {
Expand Down
6 changes: 5 additions & 1 deletion app/retail/templates/home/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,11 @@ <h2 class="font-title-xl mt-4">

<img class="w-100 mb-5" src="{% static "v2/images/home/story.svg" %}" />

<div id="optimize_oss" class="mt-5 optimize_oss">
<div class="container-fluid pb-5 my-5 landing__newsletter">
{% include 'shared/newsletter.html' %}
</div>

<div id="optimize_oss" class="mt-5 pt-4 optimize_oss">
<div class="container pt-0">
<div class="row">
<div class="col-12 col-md-8 col-lg-6 g-fadein" data-fade-duration=1000 data-fade-direction="left">
Expand Down
3 changes: 3 additions & 0 deletions app/retail/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,6 +206,9 @@ def index(request):
'know_us': know_us,
'press': press,
'articles': articles,
'hide_newsletter_caption': True,
Copy link
Contributor

@octavioamu octavioamu Jul 23, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what are these 2 for?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

newletter use those 2 to show more label on the newsletter
If we are not using it -> we can remove it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this tested? Why make these changes to the newsletter?

'hide_newsletter_consent': True,
'newsletter_headline': _("Get the Latest Gitcoin News! Join Our Newsletter."),
'title': _('Grow Open Source: Get crowdfunding and find freelance developers for your software projects, paid in crypto')
}
return TemplateResponse(request, 'home/index.html', context)
Expand Down