Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add email capture to landing #4847

Merged
merged 2 commits into from
Jul 24, 2019
Merged

feat: add email capture to landing #4847

merged 2 commits into from
Jul 24, 2019

Conversation

thelostone-mc
Copy link
Member

@thelostone-mc thelostone-mc commented Jul 23, 2019 •
edited
Loading

Description

Add the email capture functionality onto the landing page
cc @octavioamu would like you to double-check this

Note: Also added hide_newsletter_caption': True
to ensure we don't show the withdraw email consent / we won't sell your data text

Refers/Fixes

closes #4846

Testing

Screenshot 2019-07-23 at 10 12 41 AM

octavioamu
octavioamu reviewed Jul 23, 2019
View reviewed changes
app/retail/views.py
@@ -206,6 +206,9 @@ def index(request):
'know_us': know_us,
'press': press,
'articles': articles,
'hide_newsletter_caption': True,
Copy link
Contributor

@octavioamu octavioamu Jul 23, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what are these 2 for?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

newletter use those 2 to show more label on the newsletter
If we are not using it -> we can remove it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this tested? Why make these changes to the newsletter?

@codecov
Copy link

codecov bot commented Jul 23, 2019

Codecov Report

Merging #4847 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4847   +/-   ##
=======================================
  Coverage   30.43%   30.43%           
=======================================
  Files         216      216           
  Lines       17333    17333           
  Branches     2353     2353           
=======================================
  Hits         5276     5276           
  Misses      11848    11848           
  Partials      209      209
Impacted Files Coverage Δ
app/retail/views.py 29.26% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce2e23f...8adf712. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 23, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@3d699c7). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #4847   +/-   ##
========================================
  Coverage          ?   30.4%           
========================================
  Files             ?     216           
  Lines             ?   17339           
  Branches          ?    2353           
========================================
  Hits              ?    5272           
  Misses            ?   11858           
  Partials          ?     209
Impacted Files Coverage Δ
app/retail/views.py 29.26% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d699c7...37acecd. Read the comment docs.

octavioamu
octavioamu approved these changes Jul 23, 2019
View reviewed changes
Copy link
Contributor

@octavioamu octavioamu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm just left a question

@danlipert danlipert merged commit 6b66f95 into gitcoinco:master Jul 24, 2019
@thelostone-mc thelostone-mc deleted the mail branch January 16, 2020 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@octavioamu octavioamu octavioamu approved these changes

@danlipert danlipert danlipert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Email Capture to Main Gitcoin.co landing page
3 participants
@thelostone-mc @danlipert @octavioamu