-
-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Choose persona modal #4727
Choose persona modal #4727
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4727 +/- ##
=======================================
Coverage 30.41% 30.41%
=======================================
Files 216 216
Lines 17223 17223
Branches 2332 2332
=======================================
Hits 5239 5239
Misses 11776 11776
Partials 208 208
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #4727 +/- ##
==========================================
- Coverage 30.44% 30.43% -0.02%
==========================================
Files 216 216
Lines 17255 17272 +17
Branches 2340 2344 +4
==========================================
+ Hits 5254 5256 +2
- Misses 11793 11808 +15
Partials 208 208
Continue to review full report at Codecov.
|
@octavioamu - is the |
yes I need to add into the settings but should work on your local. What problem are you having? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few minor comments !
Also worth changing all the var declaration to const /let ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good! Just a few minor changes
@danlipert check the updates files I think was everything done but let me know if you find anything new |
is there a migraiton somewhere that sets the initial is_persona_hunter or is_persona_funder fields? looks like my profile is set as a hunter, and that's def wrong. i'm a stronger funder than i am a hunter |
@owocki @frankchen07 Maybe we should adjust the algorithm to be more funder-sensitive - the fields are set by a cronjob that runs daily |
@owocki if you want to check the logic https://github.com/gitcoinco/web/pull/4481/files |
whats with this SQL? (a) why long SQL? (b) it says i'm a hunter and not a funder :(
|
Description
Refers/Fixes
Ref #4665 #4511
Testing