Add send_weekly_recap to crontab #4604

iamonuwa · 2019-06-10T10:12:12Z

Description

Add send_weekly_recap to crontab

Refers/Fixes

Testing

codecov · 2019-06-10T10:16:39Z

Codecov Report

Merging #4604 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4604      +/-   ##
==========================================
- Coverage   30.12%   30.09%   -0.04%     
==========================================
  Files         210      210              
  Lines       16911    16911              
  Branches     2284     2284              
==========================================
- Hits         5095     5089       -6     
- Misses      11619    11625       +6     
  Partials      197      197

Impacted Files	Coverage Δ
app/dashboard/embed.py	`28.16% <0%> (-3.45%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b17efb5...2319cdd. Read the comment docs.

codecov · 2019-06-10T10:16:40Z

Codecov Report

Merging #4604 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4604      +/-   ##
==========================================
- Coverage   30.12%   30.09%   -0.04%     
==========================================
  Files         210      210              
  Lines       16911    16911              
  Branches     2284     2284              
==========================================
- Hits         5095     5089       -6     
- Misses      11619    11625       +6     
  Partials      197      197

Impacted Files	Coverage Δ
app/dashboard/embed.py	`28.16% <0%> (-3.45%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b17efb5...2319cdd. Read the comment docs.

thelostone-mc · 2019-06-11T15:36:04Z

@iamonuwa could you

give more context on why this is needed
has it been tested / if not why

^ this is to ensure the reviewer has enough info to review this PR to merge it in

iamonuwa · 2019-06-11T16:11:56Z

@thelostone-mc, I figured it was the remaining piece of the puzzle after with @kuhnchris and
@PixelantDesign

owocki · 2019-06-11T19:50:59Z

whats the reference issue?

are we sure the weekly recap email is high quality enough that we're ready to send it to everyone?

iamonuwa · 2019-06-11T21:47:41Z

#3013

…

On Tue, 11 Jun 2019, 20:51 Kevin Owocki, ***@***.***> wrote: whats the reference issue? are we sure the weekly recap email is high quality enough that we're ready to send it to everyone? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#4604?email_source=notifications&email_token=ABR7MNRV3PNCOKKK2HZAGMTPZ762PA5CNFSM4HWSFYA2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXOJX6A#issuecomment-500997112>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABR7MNWVGIEPXSF6CHGZW3LPZ762PANCNFSM4HWSFYAQ> .

thelostone-mc · 2019-06-12T05:50:20Z

are we sure the weekly recap email is high quality enough that we're ready to send it to everyone?

@iamonuwa we won't be getting this in until that is verified cause this would endup going to our users if merged ! Would you be able to verify it & provide screenshots ?

kuhnchris · 2019-06-12T07:59:22Z

@thelostone-mc do we finally have a easy solution to test mails without them actually going out? Because right now we barely can test this at all.

PixelantDesign · 2019-06-14T10:48:13Z

A screenshot would be great!

iamonuwa · 2019-06-14T11:48:12Z

It keeps failing for me

…

On Fri, 14 Jun 2019, 11:48 Pixelant, ***@***.***> wrote: A screenshot would be great! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#4604?email_source=notifications&email_token=ABR7MNQDLK5E55UB4XIYJV3P2NZPDA5CNFSM4HWSFYA2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXWN7WA#issuecomment-502063064>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABR7MNWZTILB45DKCN2L36LP2NZPDANCNFSM4HWSFYAQ> .

thelostone-mc · 2019-06-23T19:21:49Z

@kuhnchris well if the needed data is present in db
@iamonuwa could

add a new test route like it's done for other emails
simply visit that url and see the mail

Taking it a step further you could add SENDGRID_API_KEY in your env and update the code to trigger the mail to be sent only to your mail

^ Those are the 2 ways I can think of !

I know it's cumbersome but we can't afford to merge this in without testing

cc @danlipert / @octavioamu

iamonuwa · 2019-06-23T19:32:32Z

@kuhnchris well if the needed data is present in db
@iamonuwa could

add a new test route like it's done for other emails

simply visit that url and see the mail

Taking it a step further you could add SENDGRID_API_KEY in your env and update the code to trigger the mail to be sent only to your mail

^ Those are the 2 ways I can think of !

I know it's cumbersome but we can't afford to merge this in without testing

cc @danlipert / @octavioamu

Totally agree. The only issue ATM is if the data is present

danlipert · 2019-06-28T13:40:05Z

I honestly don't think this is valuable - right now we do manual testing to see if the email is formatted correctly, etc by sending ourselves a test email before sending it out. There are usually issues that need to be addressed, and the timing of when the roundup is ready is not very stable. I'd like to see some consistency in preparing the content before we automate this.

kuhnchris · 2019-06-28T14:27:41Z

I honestly don't think this is valuable - right now we do manual testing to see if the email is formatted correctly, etc by sending ourselves a test email before sending it out. There are usually issues that need to be addressed, and the timing of when the roundup is ready is not very stable. I'd like to see some consistency in preparing the content before we automate this.

Maybe as a little background: I implemented MailDev a while ago to "locally send mails" without going out through a real mail server. Since we have a docker environment it should be pretty straight forward to include.

(see https://danfarrelly.nyc/MailDev/)

Maybe that's something to consider @danlipert ?

danlipert · 2019-07-01T14:36:34Z

I honestly don't think this is valuable - right now we do manual testing to see if the email is formatted correctly, etc by sending ourselves a test email before sending it out. There are usually issues that need to be addressed, and the timing of when the roundup is ready is not very stable. I'd like to see some consistency in preparing the content before we automate this.

Maybe as a little background: I implemented MailDev a while ago to "locally send mails" without going out through a real mail server. Since we have a docker environment it should be pretty straight forward to include.

(see https://danfarrelly.nyc/MailDev/)

Maybe that's something to consider @danlipert ?

Very cool! The manual test so much I dont worry about, but its the content being prepared on-time and accurately/bug-free.

PixelantDesign · 2019-08-07T16:02:27Z

@iamonuwa please let us know if you can help wrap this up by Friday. Otherwise I'll need to bring it in internally. Thanks!

iamonuwa · 2019-08-07T16:23:59Z

You can make it internal

rafalkowalski · 2019-08-08T14:36:57Z

@danlipert @octavioamu @thelostone-mc What exactly is missing here? Only manual testing or something else?

danlipert · 2019-08-19T15:55:36Z

I don't think this is valuable at all - right now the emails are visually checked before going out for grammar issues, etc. and I don't know how we can automate that easily.

…

-Dan Lipert

On Thu, Aug 8, 2019 at 11:37 PM Rafał Kowalski ***@***.***> wrote: @danlipert <https://github.com/danlipert> @octavioamu <https://github.com/octavioamu> @thelostone-mc <https://github.com/thelostone-mc> What exactly is missing here? Only manual testing or something else? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#4604?email_source=notifications&email_token=AAGUHEQ7K5Q6PEWI62WMCMTQDQVQ5A5CNFSM4HWSFYA2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD332LZY#issuecomment-519546343>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAGUHET7FA7R52S5SXNHZJTQDQVQ5ANCNFSM4HWSFYAQ> .

kuhnchris · 2019-08-19T16:43:11Z

I don't think this is valuable at all - right now the emails are visually checked before going out for grammar issues, etc. and I don't know how we can automate that easily.
…
-Dan Lipert
On Thu, Aug 8, 2019 at 11:37 PM Rafał Kowalski @.***> wrote: @danlipert https://github.com/danlipert @octavioamu https://github.com/octavioamu @thelostone-mc https://github.com/thelostone-mc What exactly is missing here? Only manual testing or something else? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#4604?email_source=notifications&email_token=AAGUHEQ7K5Q6PEWI62WMCMTQDQVQ5A5CNFSM4HWSFYA2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD332LZY#issuecomment-519546343>, or mute the thread https://github.com/notifications/unsubscribe-auth/AAGUHET7FA7R52S5SXNHZJTQDQVQ5ANCNFSM4HWSFYAQ .

for the weekly mails too? cause this is a mail in the style of "hey we found work for you".

Add send_weekly_recap to crontab

2319cdd

thelostone-mc closed this Feb 25, 2020

Abuchtela mentioned this pull request Oct 21, 2024

[Snyk] Security upgrade @pulumi/aws from 5.11.0 to 6.56.0 Abuchtela/web#137

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add send_weekly_recap to crontab #4604

Add send_weekly_recap to crontab #4604

iamonuwa commented Jun 10, 2019 •

edited

Loading

codecov bot commented Jun 10, 2019

codecov bot commented Jun 10, 2019 •

edited

Loading

thelostone-mc commented Jun 11, 2019

iamonuwa commented Jun 11, 2019

owocki commented Jun 11, 2019

iamonuwa commented Jun 11, 2019 via email

thelostone-mc commented Jun 12, 2019

kuhnchris commented Jun 12, 2019

PixelantDesign commented Jun 14, 2019

iamonuwa commented Jun 14, 2019 via email

thelostone-mc commented Jun 23, 2019 •

edited

Loading

iamonuwa commented Jun 23, 2019

danlipert commented Jun 28, 2019

kuhnchris commented Jun 28, 2019

danlipert commented Jul 1, 2019

PixelantDesign commented Aug 7, 2019

iamonuwa commented Aug 7, 2019

rafalkowalski commented Aug 8, 2019

danlipert commented Aug 19, 2019 via email

kuhnchris commented Aug 19, 2019

Add send_weekly_recap to crontab #4604

Add send_weekly_recap to crontab #4604

Conversation

iamonuwa commented Jun 10, 2019 • edited Loading

Description

Refers/Fixes

Testing

codecov bot commented Jun 10, 2019

Codecov Report

codecov bot commented Jun 10, 2019 • edited Loading

Codecov Report

thelostone-mc commented Jun 11, 2019

iamonuwa commented Jun 11, 2019

owocki commented Jun 11, 2019

iamonuwa commented Jun 11, 2019 via email

thelostone-mc commented Jun 12, 2019

kuhnchris commented Jun 12, 2019

PixelantDesign commented Jun 14, 2019

iamonuwa commented Jun 14, 2019 via email

thelostone-mc commented Jun 23, 2019 • edited Loading

iamonuwa commented Jun 23, 2019

danlipert commented Jun 28, 2019

kuhnchris commented Jun 28, 2019

danlipert commented Jul 1, 2019

PixelantDesign commented Aug 7, 2019

iamonuwa commented Aug 7, 2019

rafalkowalski commented Aug 8, 2019

danlipert commented Aug 19, 2019 via email

kuhnchris commented Aug 19, 2019

iamonuwa commented Jun 10, 2019 •

edited

Loading

codecov bot commented Jun 10, 2019 •

edited

Loading

thelostone-mc commented Jun 23, 2019 •

edited

Loading