Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUILD - As a Gitcoiner, I'd like to have a weekly recap on how my bounties are doing #3013

Closed
7 tasks
PixelantDesign opened this issue Nov 29, 2018 · 29 comments
Closed
7 tasks

Comments

@PixelantDesign
Copy link
Contributor

PixelantDesign commented Nov 29, 2018

User Story

As a funder, I'd like to have a weekly recap on how my bounties are doing.

Why Is this Needed

Summary: If a funder has multiple bounties being worked on, it's hard to see the status of his/her bounties at a glance.

Definition of Done

  • Build an email for weekly recap emails
  • This email should have a title
  • The user name should be dynamic
  • Please display all of the information in the mockup
  • View Bounty links to the appropriate bounty
  • Email must be responsive
  • Review with core team members

Reference

Please see #2544

48913556-b2bbaa00-eeb3-11e8-8333-ce2957339d08

@willsputra could you provide the sketch file?

@PixelantDesign PixelantDesign changed the title BUILD - As a funder, I'd like to have a weekly recap on how my bounties are doing BUILD - As a Gitcoiner, I'd like to have a weekly recap on how my bounties are doing Nov 30, 2018
@willsputra
Copy link
Contributor

@PixelantDesign edited your original post to fix the link under 'References'.

Sketch file here!
https://drive.google.com/open?id=1aKejF0wEmBXk6ezjT6DpJBOB0j1sx9Wc

@PixelantDesign
Copy link
Contributor Author

@kuhnchris as we chatted earlier lets focus on bounties first and then if we have some time at the end add in kudos sent/received below that.

@kuhnchris
Copy link
Contributor

I finished the template and loading so far, but I do have issues since I do not have any ways to simulate bounties. I can only create a couple by hand, but that doesn't really opt for a good testcase... any ideas?

@owocki
Copy link
Contributor

owocki commented Dec 11, 2018

@kuhnchris if u set your metamask to rinkeby, you can create as many bounties as you want on it! also you can use the sync_geth command to sync already-existing rinkeby bounties

@kuhnchris
Copy link
Contributor

Hi there @owocki @mbeacom helped me fixed everything up, so I already managed to get enough bounties in:

image

So those are already live data, (rinkeby), Links work, titles work, the / new_bounty is for me, since I am currently categorizing them.

One more thing: the picture on the left, do you want it to be the default profile picture, or your own (e.a. the bounty's image) or the activity person's image? If so then we also should put in (for example for apply work or drop work or whatever) the name of the person doing the change, don't you think so too @PixelantDesign ?

@PixelantDesign
Copy link
Contributor Author

Wow looking great @kuhnchris!

I know it currently shows the project icon, but what seems the most useful is the person's image, Github user name, and Github issue number and part of the description which you already have.

What do you think @willsputra ?

@willsputra
Copy link
Contributor

@PixelantDesign @kuhnchris yeah if we could put the activity person's image and username that would be great!

@kuhnchris
Copy link
Contributor

Hey there @willsputra and @PixelantDesign
What you guys think about this?

image

@kuhnchris
Copy link
Contributor

Another nightly update:
image

@willsputra is there a reason why you added such a big margin/border to the entire page? we have a standard size in the base template, which I used, If you need it really that small let me know!

@willsputra
Copy link
Contributor

Looking good @kuhnchris! I like that you've added the timestamp too 👍

Yeah I think we can stick with the standard base template. Just a couple of little tweaks:

  1. Since the timestamp is less important compared to the bounty title, I'd separate them and also make the timestamp gray
  2. Add a bit more padding between each bounty

screenshot 2018-12-14 21 02 13

@kuhnchris
Copy link
Contributor

kuhnchris commented Dec 14, 2018

Better?
image
Also, shall we add "the recent activities between <2018-12-01> and <2018-12-08>" ? (e.a. the time range of the mail)

@willsputra
Copy link
Contributor

willsputra commented Dec 14, 2018

@kuhnchris Yesss that looks great!

Good idea. Maybe we can put it with opening text (would be great if we can make the timestamp format consistent too):

"Hi mbeacom,
Here are the latest activities on your bounties
(Dec 1, 2018 - Dec 8, 2018)"

What do you think?

@kuhnchris
Copy link
Contributor

Thanks, that reminded me that I forgot to implement the date selector 😅
image
All in there~

@PixelantDesign
Copy link
Contributor Author

Looking good!

Could we make the colored lines light gray and put the time stamp under the issue title? Most issue titles will be long.

If there is an issue where a contributor is pending approval coukd we change the view bounty link to Review Worker

@kuhnchris
Copy link
Contributor

Regarding colored lines, time stamp --> @willsputra
Regarding changing the link, sure!

@willsputra
Copy link
Contributor

@kuhnchris @PixelantDesign here ya go!
screenshot 2018-12-17 22 43 20

@willsputra
Copy link
Contributor

@kuhnchris how's it goin? :)

@kuhnchris
Copy link
Contributor

My bad, currently in a bit of a transistion period. I'll add the changes tonight or tomorrow.

@PixelantDesign
Copy link
Contributor Author

Looks good! Excited to see this!

@kuhnchris
Copy link
Contributor

Hey there @willsputra and @PixelantDesign
sorry for the long delay!
image
does that look like it would fit?

Header change:
image

@PixelantDesign as we discussed, "Review" when there's a action required.
image

@willsputra
Copy link
Contributor

@kuhnchris looks good to me!

@kuhnchris
Copy link
Contributor

Thanks for checking in @willsputra!
@PixelantDesign the only thing I am not entirely sure is: is the "email sending" part of the BUILD ticket?

Or, differently asked:

  • is creating the mail sending job (= administrative task) also part of the ticket?

Thanks
Chris

@PixelantDesign
Copy link
Contributor Author

Checking on this for you @kuhnchris, could I give you an image to add to the top of the email? I know I'm scope creeping here....

@kuhnchris
Copy link
Contributor

sure, no probs

@PixelantDesign
Copy link
Contributor Author

Hey @kuhnchris please use this image above the Weekly Bounties Recap H1

weekly_robot

@kuhnchris
Copy link
Contributor

Above the H1? Well, sure, here you go:
image

@PixelantDesign
Copy link
Contributor Author

Great work!

@gitcoinbot
Copy link
Member

⚡️ A tip worth 0.55000 ETH (80.83 USD @ $146.97/ETH) has been granted to @kuhnchris for this issue from @PixelantDesign. ⚡️

The sender had the following public comments:

Thanks for the great work!

Nice work @kuhnchris! Your tip has automatically been deposited in the ETH address we have on file.

@kuhnchris
Copy link
Contributor

As I said, it's still not done, but thanks for the tip, we'll finish it up as soon as we have some test data on stage and/or live, depending on where we can use it to work with. ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants