#4515 - GRANTS - Adding sorting

[kuhnchris]

Description

add sorting for subscriptions, cancelled_subscriptions and contributors

Refers/Fixes

Fixes: #4515

Testing

Works

Thanks!

[codecov]

Codecov Report

Merging #4518 into master will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff           @@
##           master    #4518   +/-   ##
=======================================
  Coverage   30.02%   30.02%           
=======================================
  Files         209      209           
  Lines       16886    16886           
  Branches     2278     2278           
=======================================
  Hits         5070     5070           
  Misses      11619    11619           
  Partials      197      197

Impacted Files	Coverage Δ
app/grants/views.py	13.88% <0%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c31bc1f...898683b. Read the comment docs.

[codecov]

Codecov Report

Merging #4518 into master will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff           @@
##           master    #4518   +/-   ##
=======================================
  Coverage   30.17%   30.17%           
=======================================
  Files         209      209           
  Lines       16886    16886           
  Branches     2278     2278           
=======================================
  Hits         5095     5095           
  Misses      11594    11594           
  Partials      197      197

Impacted Files	Coverage Δ
app/grants/views.py	13.88% <0%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e9e414...73d254f. Read the comment docs.

[danlipert]

Hey @kuhnchris - why can't you test this locally? Just create a grant, then use test users to subscribe to it and take other actions to see if they are ordered correctly in the page.

[kuhnchris]

Hey @kuhnchris - why can't you test this locally? Just create a grant, then use test users to subscribe to it and take other actions to see if they are ordered correctly in the page.

because they need to separated by days, or do you happen to have a grant ready locally where you could test this? Cause I surely do not, I'm eagerly awaiting the test-data PR to get done...

[danlipert]

Hey @kuhnchris - why can't you test this locally? Just create a grant, then use test users to subscribe to it and take other actions to see if they are ordered correctly in the page.

because they need to separated by days, or do you happen to have a grant ready locally where you could test this? Cause I surely do not, I'm eagerly awaiting the test-data PR to get done...

You can create your own test data locally using the Django admin page and set the dates however you want.

[kuhnchris]

Hey @kuhnchris - why can't you test this locally? Just create a grant, then use test users to subscribe to it and take other actions to see if they are ordered correctly in the page.

because they need to separated by days, or do you happen to have a grant ready locally where you could test this? Cause I surely do not, I'm eagerly awaiting the test-data PR to get done...

You can create your own test data locally using the Django admin page and set the dates however you want.

well, if you say so, I can surely go and retry it, maybe you guys improved that since a couple of months ago when I first tried and failed... I'll get back at you when I got some info on this.

[danlipert]

great, thanks!

…

-Dan Lipert

On Thu, May 30, 2019 at 10:30 PM KuhnChris ***@***.***> wrote: Hey @kuhnchris <https://github.com/kuhnchris> - why can't you test this locally? Just create a grant, then use test users to subscribe to it and take other actions to see if they are ordered correctly in the page. because they need to separated by days, or do you happen to have a grant ready locally where you could test this? Cause I surely do not, I'm eagerly awaiting the test-data PR to get done... You can create your own test data locally using the Django admin page and set the dates however you want. well, if you say so, I can surely go and retry it, maybe you guys improved that since a couple of months ago when I first tried and failed... I'll get back at you when I got some info on this. — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#4518?email_source=notifications&email_token=AAGUHEUCEV73J34HO3VMVWLPX7JGRA5CNFSM4HREWG32YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWSKMBY#issuecomment-497329671>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAGUHEQ24CTZGHVGDK56VG3PX7JGRANCNFSM4HREWG3Q> .

[kuhnchris]

@danlipert it works, but...

this is technically correct but the year is missing. shall we add the year to the display?

[danlipert]

@kuhnchris nice! looking good! @willsputra what are your thoughts on adding the year?

[willsputra]

@kuhnchris @danlipert looking good! yeah having the year would be great :)

[kuhnchris]

@willsputra & @danlipert

[PixelantDesign]

Looks great @kuhnchris !

[willsputra]

@kuhnchris looks good to me!