Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activity on Grants Pages not sorted by Date #4515

Closed
dconroy opened this issue May 30, 2019 · 4 comments · Fixed by #4518
Closed

Activity on Grants Pages not sorted by Date #4515

dconroy opened this issue May 30, 2019 · 4 comments · Fixed by #4518
Labels
easy-pickings This is an easy issue for the community. good first issue This a good first issue for a community newcomer.

Comments

@dconroy
Copy link
Contributor

dconroy commented May 30, 2019

Describe the bug
On gitcoin grants pages, under the activity page, there is no discernable order to how contributions are sorted. Not by amount, date, seems random.

To Reproduce
https://gitcoin.co/grants/20/burner-wallet?tab=activity

Expected behavior
I'd expect these to arrive in date order, or atleast by amount.

Screenshots
https://dconroy.keybase.pub/gitcoin.png

Desktop (please complete the following information):

  • OS: Mac Os
  • Browser: Chrome
  • Browser Version: Version 74.0.3729.169
@PixelantDesign
Copy link
Contributor

PixelantDesign commented May 30, 2019

Thanks for the report @dconroy!

Sorting by date makes sense...from newest at the top to oldest at the bottom.

cc @frankchen07

@PixelantDesign PixelantDesign added easy-pickings This is an easy issue for the community. good first issue This a good first issue for a community newcomer. will tip for turnaround and removed will tip for turnaround labels May 30, 2019
@gitcoinbot
Copy link
Member

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 0.19 ETH (53.57 USD @ $281.93/ETH) attached to it.

@gitcoinbot
Copy link
Member

gitcoinbot commented May 30, 2019

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

These users each claimed they can complete the work by 3 weeks, 6 days from now.
Please review their action plans below:

1) kuhnchris has been approved to start work.

As discussed - implementing this ASAP

Learn more on the Gitcoin Issue Details page.

danlipert added a commit that referenced this issue May 31, 2019
@gitcoinbot
Copy link
Member

Fast Turn Around ⚡️ A *Fast Turn Around* Kudos has been sent to @kuhnchris for this issue from @PixelantDesign. ⚡️

Nice work @kuhnchris!
Your Kudos has automatically been sent in the ETH address we have on file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy-pickings This is an easy issue for the community. good first issue This a good first issue for a community newcomer.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants