Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propose work #4478

Merged
merged 7 commits into from
May 28, 2019
Merged

Propose work #4478

merged 7 commits into from
May 28, 2019

Conversation

octavioamu
Copy link
Contributor

@octavioamu octavioamu commented May 24, 2019

Description
Refers/Fixes

#4416

Testing

profile_json['position_contributor'] = user.get_contributor_leaderboard_index()
profile_json['position_funder'] = user.get_funder_leaderboard_index()
profile_json['work_done'] = count_work_completed
profile_json['work_inprogress'] = count_work_in_progress

profile_json['job_status'] = user.job_status_verbose if user.job_search_status else None
profile_json['verification'] = user.get_my_verified_check
profile_json['avg_rating'] = user.get_average_star_rating
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^ would it be cleaner to redefine the whole bit as

profile_json = {
  id: user.id,
  ...
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thelostone-mc actually is done here #4477

@codecov
Copy link

codecov bot commented May 27, 2019

Codecov Report

Merging #4478 into master will increase coverage by 0.06%.
The diff coverage is 48.64%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4478      +/-   ##
==========================================
+ Coverage   30.08%   30.15%   +0.06%     
==========================================
  Files         209      208       -1     
  Lines       16850    16821      -29     
  Branches     2267     2259       -8     
==========================================
+ Hits         5070     5072       +2     
+ Misses      11582    11557      -25     
+ Partials      198      192       -6
Impacted Files Coverage Δ
app/dashboard/views.py 15.2% <48.64%> (+0.68%) ⬆️
app/economy/models.py 58% <0%> (-3%) ⬇️
app/grants/abi.py 0% <0%> (ø) ⬆️
app/grants/convert_abi.py
app/app/settings.py 78.76% <0%> (+0.11%) ⬆️
app/retail/views.py 29.22% <0%> (+0.37%) ⬆️
app/grants/models.py 50.71% <0%> (+0.71%) ⬆️
app/grants/views.py 14.71% <0%> (+0.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be9b701...d3f5598. Read the comment docs.

@codecov
Copy link

codecov bot commented May 27, 2019

Codecov Report

Merging #4478 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4478      +/-   ##
==========================================
- Coverage   30.09%   30.07%   -0.03%     
==========================================
  Files         209      209              
  Lines       16848    16860      +12     
  Branches     2266     2270       +4     
==========================================
  Hits         5070     5070              
- Misses      11580    11592      +12     
  Partials      198      198
Impacted Files Coverage Δ
app/dashboard/views.py 14.4% <0%> (-0.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5809b9...2062d0f. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants