Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/data changes #4477

Merged
merged 12 commits into from
May 29, 2019
Merged

Fix/data changes #4477

merged 12 commits into from
May 29, 2019

Conversation

octavioamu
Copy link
Contributor

@octavioamu octavioamu commented May 24, 2019

Description
Refers/Fixes

fix #4391

Testing

Tested the diff user data configurations

app/dashboard/views.py Outdated Show resolved Hide resolved
app/dashboard/views.py Outdated Show resolved Hide resolved
app/dashboard/views.py Outdated Show resolved Hide resolved
app/dashboard/views.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented May 24, 2019

Codecov Report

Merging #4477 into master will decrease coverage by 0.22%.
The diff coverage is 4%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4477      +/-   ##
==========================================
- Coverage   30.08%   29.86%   -0.23%     
==========================================
  Files         209      209              
  Lines       16850    16864      +14     
  Branches     2267     2267              
==========================================
- Hits         5070     5036      -34     
- Misses      11582    11640      +58     
+ Partials      198      188      -10
Impacted Files Coverage Δ
app/dashboard/views.py 13.07% <4%> (-1.44%) ⬇️
app/economy/models.py 58% <0%> (-3%) ⬇️
app/dashboard/models.py 55.63% <0%> (-0.94%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d59ae5c...83221f6. Read the comment docs.

@codecov
Copy link

codecov bot commented May 24, 2019

Codecov Report

Merging #4477 into master will decrease coverage by 0.02%.
The diff coverage is 35%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4477      +/-   ##
==========================================
- Coverage   30.07%   30.04%   -0.03%     
==========================================
  Files         209      209              
  Lines       16862    16864       +2     
  Branches     2270     2272       +2     
==========================================
- Hits         5071     5067       -4     
- Misses      11593    11601       +8     
+ Partials      198      196       -2
Impacted Files Coverage Δ
app/dashboard/views.py 14.29% <35%> (-0.11%) ⬇️
app/economy/models.py 58% <0%> (-3%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe5b990...a54da8a. Read the comment docs.

@octavioamu octavioamu requested a review from danlipert May 24, 2019 19:57
Copy link
Contributor

@danlipert danlipert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! One style comment

app/dashboard/views.py Outdated Show resolved Hide resolved
@octavioamu octavioamu mentioned this pull request May 27, 2019
@octavioamu
Copy link
Contributor Author

Ready to review @danlipert

@danlipert danlipert merged commit c9b68e2 into master May 29, 2019
@thelostone-mc thelostone-mc deleted the fix/data-changes branch July 4, 2019 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User List - CV links go into the void
2 participants