-
-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/data changes #4477
Fix/data changes #4477
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4477 +/- ##
==========================================
- Coverage 30.08% 29.86% -0.23%
==========================================
Files 209 209
Lines 16850 16864 +14
Branches 2267 2267
==========================================
- Hits 5070 5036 -34
- Misses 11582 11640 +58
+ Partials 198 188 -10
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #4477 +/- ##
==========================================
- Coverage 30.07% 30.04% -0.03%
==========================================
Files 209 209
Lines 16862 16864 +2
Branches 2270 2272 +2
==========================================
- Hits 5071 5067 -4
- Misses 11593 11601 +8
+ Partials 198 196 -2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! One style comment
Ready to review @danlipert |
Description
Refers/Fixes
fix #4391
Testing
Tested the diff user data configurations