Grant fee rebase #4453
Merged
Grant fee rebase #4453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4453 +/- ##
==========================================
- Coverage 30.12% 29.79% -0.34%
==========================================
Files 208 209 +1
Lines 16791 17266 +475
Branches 2255 2385 +130
==========================================
+ Hits 5059 5144 +85
- Misses 11537 11915 +378
- Partials 195 207 +12
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #4453 +/- ##
==========================================
+ Coverage 30.14% 30.16% +0.02%
==========================================
Files 208 209 +1
Lines 16798 16846 +48
Branches 2257 2266 +9
==========================================
+ Hits 5063 5081 +18
- Misses 11538 11565 +27
- Partials 197 200 +3
Continue to review full report at Codecov.
|
- introduces section to let users choose % for gitcoin contribution - summary reflects based on users selection - code refactor
danlipert
force-pushed
the
grant_fee_rebase
branch
from
484c348 to
aee6d87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rebased version of @thelostone-mc and I's grant fee implementation
Refers/Fixes
#4376
Testing
Tested manually - use
grants/oldto create a "v0" version of a grant to test how current grants with the v0 contract will work