Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grant/new: contribute to gitcoin grant (dual contribution) #4376

Closed
wants to merge 26 commits into from

Conversation

thelostone-mc
Copy link
Member

@thelostone-mc thelostone-mc commented May 13, 2019

Description

This PR is a 2 step process to allow users to contribute to 2 grants at the same time. (latter being the gitcoin grant ).
Users would be allowed to give X% of their Y contribution during the funding process as shown in the demo of step1

Step1 (Complete)
  • introduces section to let users choose % for gitcoin contribution
  • summary reflects based on users selection
  • code refactor

Demo: https://embed.vidyard.com/share/msPVKEiMWqbA1ueY9yxeg3?

Step2 ( NOT DONE )
  • wire in splitter contract
  • ensure right amount are being passed

cc @danlipert

Refers/Fixes

#4106

- introduces section to let users choose % for gitcoin contribution
- summary reflects based on users selection
- code refactor
@thelostone-mc thelostone-mc changed the title Grant fee grant/new: contribute to gitcoin grant (dual contribution) May 13, 2019
@thelostone-mc thelostone-mc added the Gitcoin Grants Gitcoin Grants label May 13, 2019
@danlipert danlipert mentioned this pull request May 22, 2019
@danlipert danlipert closed this May 22, 2019
@thelostone-mc thelostone-mc deleted the grant_fee branch July 4, 2019 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gitcoin Grants Gitcoin Grants
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants