Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

newsletter0510 #4372

Merged
merged 3 commits into from
May 16, 2019
Merged

newsletter0510 #4372

merged 3 commits into from
May 16, 2019

Conversation

vs77bb
Copy link
Contributor

@vs77bb vs77bb commented May 10, 2019

Description
Refers/Fixes
Testing

@vs77bb vs77bb requested review from owocki and danlipert May 10, 2019 14:07
@codecov
Copy link

codecov bot commented May 15, 2019

Codecov Report

Merging #4372 into stable will decrease coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           stable    #4372      +/-   ##
==========================================
- Coverage   30.18%   30.15%   -0.04%     
==========================================
  Files         209      209              
  Lines       16794    16794              
  Branches     2251     2251              
==========================================
- Hits         5070     5064       -6     
- Misses      11531    11540       +9     
+ Partials      193      190       -3
Impacted Files Coverage Δ
app/retail/emails.py 21.52% <0%> (ø) ⬆️
app/dashboard/utils.py 33% <0%> (-1.49%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9abc68a...2abd8db. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented May 15, 2019

Codecov Report

Merging #4372 into stable will decrease coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           stable    #4372      +/-   ##
==========================================
- Coverage   30.18%   30.15%   -0.04%     
==========================================
  Files         209      209              
  Lines       16794    16794              
  Branches     2251     2251              
==========================================
- Hits         5070     5064       -6     
- Misses      11531    11540       +9     
+ Partials      193      190       -3
Impacted Files Coverage Δ
app/retail/emails.py 21.52% <0%> (ø) ⬆️
app/dashboard/utils.py 33% <0%> (-1.49%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9abc68a...2abd8db. Read the comment docs.

@owocki
Copy link
Contributor

owocki commented May 15, 2019

LGTM @vs77bb @danlipert

@thelostone-mc
Copy link
Member

merging it in 🙌

@thelostone-mc thelostone-mc merged commit 72e7849 into stable May 16, 2019
@thelostone-mc thelostone-mc deleted the newsletter0510 branch July 4, 2019 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants