Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: notify funder to extend expiration date before taking action #4161

Merged
merged 1 commit into from
Apr 10, 2019

Conversation

thelostone-mc
Copy link
Member

Description
  • refactored code
  • the text pops up only when the following conditions are all met
    a) bounty is expired
    b) logged in user is bounty owner (with the right metamask address )
    c) issue has not been done / cancelled

Untitled

closes #4110

@codecov
Copy link

codecov bot commented Apr 9, 2019

Codecov Report

Merging #4161 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4161      +/-   ##
==========================================
- Coverage   30.26%   30.22%   -0.04%     
==========================================
  Files         206      206              
  Lines       16367    16367              
  Branches     2154     2154              
==========================================
- Hits         4953     4947       -6     
- Misses      11238    11244       +6     
  Partials      176      176
Impacted Files Coverage Δ
app/dashboard/embed.py 28.16% <0%> (-3.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 808072f...542379d. Read the comment docs.

@SaptakS SaptakS merged commit 2bb3953 into gitcoinco:master Apr 10, 2019
@thelostone-mc thelostone-mc deleted the dets branch July 4, 2019 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

As a bounty funder, if my bounty is expired, I can't payout.
3 participants