Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix matching logic #4050

Merged
merged 5 commits into from
Mar 28, 2019
Merged

Fix matching logic #4050

merged 5 commits into from
Mar 28, 2019

Conversation

SaptakS
Copy link
Contributor

@SaptakS SaptakS commented Mar 27, 2019

Description
  • This PR ensures that all the matchings use the same matching logic (i.e. the keyword property described in model which checks for a keyword in keywords, issue title, issue description).
  • While fixing this, I also noticed that all the keywords were not being saved, so fixed that too.
  • Currently, in explorer when we search (also from onboarding) it wasn't checking for all the keywords in the comma separated string. Instead it was either checking the first keyword or the entire string thus not always giving good result. So modified queryset query to give an union of all the queries with the different keyword.

For simplicity of review, I have made separate commits for each.

Checklist
Affected core subsystem(s)

Search and matching

Refers/Fixes

Fixes #3990
Fixes #4048

@codecov
Copy link

codecov bot commented Mar 27, 2019

Codecov Report

Merging #4050 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4050      +/-   ##
==========================================
- Coverage   30.22%   30.19%   -0.03%     
==========================================
  Files         205      205              
  Lines       16240    16234       -6     
  Branches     2139     2136       -3     
==========================================
- Hits         4908     4902       -6     
  Misses      11158    11158              
  Partials      174      174
Impacted Files Coverage Δ
app/dashboard/router.py 30.25% <0%> (-0.64%) ⬇️
...arketing/management/commands/new_bounties_email.py 0% <0%> (ø) ⬆️
app/dashboard/embed.py 28.16% <0%> (-3.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b6acd5...b97b907. Read the comment docs.

Copy link
Contributor

@danlipert danlipert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Tested locally and works great!

@danlipert danlipert merged commit eb82d9a into gitcoinco:master Mar 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bounties not storing all the keywords Backend - Fix Matching Logic
5 participants