more designs added

[mehul0698]

Description

Checklist

• Read and conforms to the contributor guidelines
• Read and conforms to the style guidelines
• Linter status: 100% pass
• Added relevant tests
• Tests pass and code coverage has not decreased
• Changes don't break existing behavior
• Commit message follows commit guidelines
• Code documentation
• Completed: Code review by core team and any requested changes

Affected core subsystem(s)

Refers/Fixes

Testing and Sign-off

Contributor

• Read and followed the Contributor Guidelines
• Tested all changes locally
• Verified existing functionality
• Ran make test and everything passed!

Reviewer

• Affirm contributor guidelines have been followed and requested changes made
• CI tests and linting pass
• No conflicts (migrations, files, etc)
• Regression tested against staging or local deployment

Funder

• Validated requested changes were made to specification
• Bounty payout released to the contributor

[mehul0698]

[mehul0698]

@owocki @thelostone-mc I have added 7 more accessories. The last one is a sword. It looks very cool, do check that out. Please review the pr.

[codecov]

Codecov Report

Merging #4025 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4025   +/-   ##
=======================================
  Coverage   30.07%   30.07%           
=======================================
  Files         205      205           
  Lines       16006    16006           
  Branches     2111     2111           
=======================================
  Hits         4814     4814           
  Misses      11020    11020           
  Partials      172      172

Impacted Files	Coverage Δ
app/avatar/utils.py	13.43% <ø> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c87441...e6aa79c. Read the comment docs.

[codecov]

Codecov Report

Merging #4025 into master will decrease coverage by 12.9%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #4025       +/-   ##
===========================================
- Coverage   30.07%   17.16%   -12.91%     
===========================================
  Files         205      194       -11     
  Lines       16000    15920       -80     
  Branches     2109     2107        -2     
===========================================
- Hits         4812     2733     -2079     
- Misses      11017    13178     +2161     
+ Partials      171        9      -162

Impacted Files	Coverage Δ
app/avatar/utils.py	13.43% <ø> (ø)	⬆️
app/kudos/forms.py	0% <0%> (-100%)	⬇️
app/grants/serializers.py	0% <0%> (-100%)	⬇️
app/avatar/serializers.py	0% <0%> (-100%)	⬇️
app/grants/urls.py	0% <0%> (-100%)	⬇️
app/inbox/urls.py	0% <0%> (-100%)	⬇️
app/avatar/urls.py	0% <0%> (-100%)	⬇️
app/grants/forms.py	0% <0%> (-100%)	⬇️
app/avatar/router.py	0% <0%> (-90.91%)	⬇️
app/app/urls.py	0% <0%> (-90%)	⬇️
... and 78 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8cd6b4a...da0edec. Read the comment docs.

[mehul0698]

Hey did you see the pictures I posted on the other thread with all the misplaced assets?

[thelostone-mc]

@mehul0698 mind tagging the link here ?

[mehul0698]

@thelostone-mc #3971

[mehul0698]

@thelostone-mc don't merge this pr. I'll push the corrected assets on this branch.

[mehul0698]

More mistakes

[mehul0698]

[mehul0698]

@thelostone-mc I have corrected 6 assets. Please review the pr.

[thelostone-mc]

Ah man you da best ❤️ Thanks for fixing those up
cc @owocki

[mehul0698]

Will I get paid for correcting them?

[owocki]

hey -- before i answer that question @mehul0698 -- who originally added the assets that were misplaced? does your fix apply across all assets / how can we prevent this in the future? how did you fix them and how much time did it take per asset

[mehul0698]

@owocki I think the assets were added by yash412. I have fixed the ones that I was able to find. To prevent in this future you just ask them to upload 2 pictures for each asset one in avatar builder and one once it is saved as the problem with these assets was not in the avatar builder but once they were saved they appeared out of place. 4 of these I had to resize and make minor changes and change their .txt file but the bird and necklace I made them from scratch as resizing was not working for them. For all the assets that I make upload 2 pictures to give you the assurance that they will work anywhere and that they meet size criteria. The problem with some of these assets was that the artboard size was messed up and once I corrected that the asset got messed up so had to redo a lot in it. I hope this helps.

[mehul0698]

@owocki I think there might be more as when I was looking for inspiration I found these.

[owocki]

@mehul0698 did you correct the artboard sizes in sketch? if so, are there guidelines with respect to artboard sizes we should start enforcing?

[mehul0698]

Yes and do make sure they upload both pictures as it might look alright in the avatar builder but once saved it appears out of place. In the bounty description you have mentioned the gitcoin style guide in one line. I suggest you put more emphasis on that as some designs dont even follow the colour guidelines. Mainly I saw some developer using a misplaced asset on gitcoin and does not look good for the brand.

[mehul0698]

@owocki the mail you sent about avatars to everyone also had misplaced assets. The one I got was also in bad shape.

[mehul0698]

Look at this one.

[mehul0698]

@owocki The black partial background ruins this clothing option. No one is going to use this.

[mehul0698]

In the avatar builder this looks fine.

[mehul0698]

@owocki This one also.

[mehul0698]

@owocki The pr has been merged. I made 7 accessories out of which I consider 4 to be exotic. You owe me around 125 to 130 dollars.
If its fine by you I corrected 6 accessories out of which 2 I had to make from scratch, for that you could pay me 50 to 60 dollars.
If you want I could look into other messed up assets also. TIA

[mehul0698]

@owocki do you want me to look into other assets?

[mehul0698]

@owocki @thelostone-mc I have made 2 more designs should put a pr?

[owocki]

sorry, was away for the weekend. yes pls PR the last two designs

[mehul0698]

@owocki As avengers endgame is about to release so one of them is avengers related. If it contains the avengers logo will it have any proprietary problems?

[owocki]

its probably not a great idea to include anything proprietary. it can be inspired by avengers, but not lifted from avengers

[mehul0698]

Cool. I'll change it.

[owocki]

@mehul0698 hey just got back from traveling. whats our tab up to now? i see i paid you 1.1 ETH about 6 days ago

[mehul0698]

All previous payments are done except this pr. This was merged 5 days ago.
I made 7 accessories out of which I consider 4 to be exotic. You owe me around 125 to 130 dollars.
If its fine by you I corrected 6 accessories out of which 2 I had to make from scratch, for that you could pay me 50 to 60 dollars.
I have put another pr with 3 designs #4040

[owocki]

ok so 175 to 190?

[mehul0698]

Yes. Thanks

[gitcoinbot]

⚡️ A tip worth 1.35000 ETH (180.1 USD @ $133.41/ETH) has been granted to @mehul0698 for this issue from @owocki. ⚡️

Nice work @mehul0698! Your tip has automatically been deposited in the ETH address we have on file.

• $49217.70 in Funded OSS Work Available at: https://gitcoin.co/explorer
• Incentivize contributions to your repo: Send a Tip or Fund a PR
• No Email? Get help on the Gitcoin Slack