Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more designs added #3971

Merged
merged 2 commits into from
Mar 19, 2019
Merged

more designs added #3971

merged 2 commits into from
Mar 19, 2019

Conversation

mehul0698
Copy link
Contributor

@mehul0698 mehul0698 commented Mar 14, 2019

Description
Checklist
Affected core subsystem(s)
Refers/Fixes
Testing and Sign-off
Contributor
  • Read and followed the Contributor Guidelines
  • Tested all changes locally
  • Verified existing functionality
  • Ran make test and everything passed!
Reviewer
  • Affirm contributor guidelines have been followed and requested changes made
  • CI tests and linting pass
  • No conflicts (migrations, files, etc)
  • Regression tested against staging or local deployment
Funder
  • Validated requested changes were made to specification
  • Bounty payout released to the contributor

@mehul0698
Copy link
Contributor Author

image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image

@codecov
Copy link

codecov bot commented Mar 14, 2019

Codecov Report

Merging #3971 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3971   +/-   ##
=======================================
  Coverage   30.01%   30.01%           
=======================================
  Files         205      205           
  Lines       15994    15994           
  Branches     2111     2111           
=======================================
  Hits         4801     4801           
  Misses      11021    11021           
  Partials      172      172
Impacted Files Coverage Δ
app/avatar/utils.py 13.43% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efdae2b...fcb25df. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 14, 2019

Codecov Report

Merging #3971 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3971   +/-   ##
=======================================
  Coverage   30.01%   30.01%           
=======================================
  Files         205      205           
  Lines       15998    15998           
  Branches     2111     2111           
=======================================
  Hits         4802     4802           
  Misses      11024    11024           
  Partials      172      172
Impacted Files Coverage Δ
app/avatar/utils.py 13.43% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe15726...3189f5b. Read the comment docs.

@mehul0698
Copy link
Contributor Author

@owocki @thelostone-mc I have added 6 accessories and 2 clothing options. Please review the pr and let me know if any changes are required.

@mehul0698 mehul0698 mentioned this pull request Mar 15, 2019
5 tasks
@mehul0698
Copy link
Contributor Author

@owocki @thelostone-mc please review this pr. Thanks

@thelostone-mc thelostone-mc merged commit e8662ba into gitcoinco:master Mar 19, 2019
@mehul0698
Copy link
Contributor Author

@owocki my pr has been merged. I made 2 clothing assests and 6 accessories out of which I consider 4 to be exotic. You owe me anything around 160 to 170 dollars.

@gitcoinbot
Copy link
Member

⚡️ A tip worth 1.15000 ETH (158.95 USD @ $138.21/ETH) has been granted to @mehul0698 for this issue from @owocki. ⚡️

Nice work @mehul0698! Your tip has automatically been deposited in the ETH address we have on file.

@mehul0698 mehul0698 deleted the more_assets branch March 21, 2019 08:45
@mehul0698
Copy link
Contributor Author

@owocki @thelostone-mc I have observed that a lot of assets in accessories have some error as when we save them they do not fit on the avatar and are placed at random places.

@mehul0698
Copy link
Contributor Author

image
The eye patch is not at its correct place.

@mehul0698
Copy link
Contributor Author

image
Here the marshmello mask appears in the corner and the glasses are misplaced.

@mehul0698
Copy link
Contributor Author

@owocki @thelostone-mc If you want I can look into this.

@mehul0698 mehul0698 mentioned this pull request Mar 21, 2019
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants