-
-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made the requested changes! #3827
Conversation
@yash412 conflicts still persist :P |
Codecov Report
@@ Coverage Diff @@
## master #3827 +/- ##
=======================================
Coverage 29.56% 29.56%
=======================================
Files 201 201
Lines 15519 15519
Branches 2036 2036
=======================================
Hits 4588 4588
Misses 10776 10776
Partials 155 155
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #3827 +/- ##
===========================================
+ Coverage 16.91% 29.56% +12.64%
===========================================
Files 191 201 +10
Lines 15510 15519 +9
Branches 2044 2036 -8
===========================================
+ Hits 2624 4588 +1964
+ Misses 12877 10776 -2101
- Partials 9 155 +146
Continue to review full report at Codecov.
|
Can you review them again @thelostone-mc! |
These are the names of the newer assets, yet it is appearing as a conflict. Can you suggest what needs to be done? @thelostone-mc |
Took care of it ^_^ |
@thelostone-mc just out of curiosity, what was the issue? |
@yash412 I just pulled it in and resolved the conflicts. |
⚡️ A tip worth 1.05000 ETH (144.08 USD @ $137.22/ETH) has been granted to @yash412 for this issue from @owocki. ⚡️ Nice work @yash412! Your tip has automatically been deposited in the ETH address we have on file.
|
Description
Solved the conflicts, made the Elf-Hat little wider and ran SVGO on the svg files.
I made multiple new items on the previous PR.
PR for reference - #3825
Checklist
Affected core subsystem(s)
Refers/Fixes
Testing and Sign-off
Contributor
make test
and everything passed!Reviewer
Funder