Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes and New Files #3825

Closed
wants to merge 2 commits into from
Closed

Changes and New Files #3825

wants to merge 2 commits into from

Conversation

yashmathne
Copy link
Contributor

Description

As discussed with @owocki, I have added a new Pirate's Eye and few other accessories.

1 ) New Updated Pirate Eye Patch

Old One -
screenshot 2019-02-23 at 4 26 01 pm

New One -
screenshot 2019-02-23 at 3 41 39 pm

2 ) Exotic Bird
screenshot 2019-02-23 at 3 38 54 pm

3 ) New Beach Necklace
screenshot 2019-02-23 at 3 39 21 pm

4 ) Tribal Earrings
screenshot 2019-02-23 at 3 39 52 pm

5 ) Google Cardboard
screenshot 2019-02-23 at 3 40 27 pm

6 ) Marshmellow?
screenshot 2019-02-23 at 3 41 15 pm

7 ) Superhero Mask with Transparent Eyes
screenshot 2019-02-23 at 3 42 05 pm

8 ) Festive Elf Hat
screenshot 2019-02-23 at 3 42 37 pm

9 ) Sleepy Hat
screenshot 2019-02-23 at 3 38 54 pm

Checklist
Affected core subsystem(s)
Refers/Fixes
Testing and Sign-off
Contributor
  • Read and followed the Contributor Guidelines
  • Tested all changes locally
  • Verified existing functionality
  • Ran make test and everything passed!
Reviewer
  • Affirm contributor guidelines have been followed and requested changes made
  • CI tests and linting pass
  • No conflicts (migrations, files, etc)
  • Regression tested against staging or local deployment
Funder
  • Validated requested changes were made to specification
  • Bounty payout released to the contributor

@yashmathne yashmathne mentioned this pull request Feb 23, 2019
5 tasks
Copy link
Member

@thelostone-mc thelostone-mc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yash412 Sweet assets but could you

  • run svgo to compress the images
  • resolve conflicts
  • make the sleepy had a tad bit bigger

@yashmathne yashmathne closed this Feb 23, 2019
@yashmathne yashmathne mentioned this pull request Feb 23, 2019
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants