Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web3/1.0 #2994

Closed
wants to merge 2 commits into from
Closed

Web3/1.0 #2994

wants to merge 2 commits into from

Conversation

pinkiebell
Copy link
Contributor

@pinkiebell pinkiebell commented Nov 29, 2018

Tested:

  • onepager
  • funding / funding erc20
  • bounty details
  • ens < until post to backend; backend not configured
  • payout
  • advanced payout
  • cancel bounty
  • submit fulfillment
  • accept fulfillment
  • increase payout
  • faucet
  • settings
  • bounty requests
  • kudos

Fixes #2370

app/assets/onepager/js/send.js Outdated Show resolved Hide resolved
app/assets/onepager/js/send.js Outdated Show resolved Hide resolved
app/assets/v2/js/metamask-approval.js Show resolved Hide resolved
app/assets/v2/js/metamask-approval.js Show resolved Hide resolved
app/assets/v2/js/metamask-approval.js Outdated Show resolved Hide resolved
app/assets/v2/js/pages/kudos_details.js Outdated Show resolved Hide resolved
app/assets/v2/js/pages/kudos_send.js Outdated Show resolved Hide resolved
app/assets/v2/js/pages/kudos_send.js Outdated Show resolved Hide resolved
app/assets/v2/js/shared.js Outdated Show resolved Hide resolved
app/assets/v2/js/truncate-hash.js Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Nov 29, 2018

Codecov Report

Merging #2994 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2994      +/-   ##
==========================================
- Coverage   29.61%   29.56%   -0.05%     
==========================================
  Files         185      185              
  Lines       14684    14684              
  Branches     1942     1942              
==========================================
- Hits         4348     4342       -6     
- Misses      10197    10203       +6     
  Partials      139      139
Impacted Files Coverage Δ
app/dashboard/embed.py 28.16% <0%> (-3.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 657b97a...1009bd5. Read the comment docs.

@mbeacom mbeacom changed the title Web3/1.0 [WIP] Web3/1.0 Nov 29, 2018
@mbeacom mbeacom added wip frontend This needs frontend expertise. labels Nov 29, 2018
@mbeacom mbeacom requested a review from a team November 29, 2018 13:36
@pinkiebell
Copy link
Contributor Author

@mbeacom Thanks for the changed title, I forgot that to change 😺 .

I need to change a few things back, I will let you know if ready

@pinkiebell
Copy link
Contributor Author

Ready for testing. I will resolve the lint issues afterwards 👍

app/assets/v2/js/pages/kudos_send.js Outdated Show resolved Hide resolved
app/assets/v2/js/pages/kudos_send.js Outdated Show resolved Hide resolved
@pinkiebell pinkiebell changed the title [WIP] Web3/1.0 Web3/1.0 Jan 3, 2019
@pinkiebell
Copy link
Contributor Author

Rebased & ready for review 🎅

@owocki
Copy link
Contributor

owocki commented Jan 16, 2019

OK this is deployed at http://kevin.stage.gitcoin.co

@owocki
Copy link
Contributor

owocki commented Jan 16, 2019

hmm i get this exception from sync/web3 when i try to post a new bounty

Traceback (most recent call last):
  File "/usr/local/lib/python3.7/site-packages/django/contrib/staticfiles/handlers.py", line 65, in __call__
    return self.application(environ, start_response)
  File "/usr/local/lib/python3.7/site-packages/django/core/handlers/wsgi.py", line 142, in __call__
    response = self.get_response(request)
  File "/usr/local/lib/python3.7/site-packages/django/core/handlers/base.py", line 78, in get_response
    response = self._middleware_chain(request)
  File "/usr/local/lib/python3.7/site-packages/django/core/handlers/exception.py", line 36, in inner
    response = response_for_exception(request, exc)
  File "/usr/local/lib/python3.7/site-packages/django/core/handlers/exception.py", line 90, in response_for_exception
    response = handle_uncaught_exception(request, get_resolver(get_urlconf()), sys.exc_info())
  File "/usr/local/lib/python3.7/site-packages/django/core/handlers/exception.py", line 125, in handle_uncaught_exception
    return debug.technical_500_response(request, *exc_info)
  File "/usr/local/lib/python3.7/site-packages/django_extensions/management/technical_response.py", line 37, in null_technical_500_response
    six.reraise(exc_type, exc_value, tb)
  File "/usr/local/lib/python3.7/site-packages/six.py", line 692, in reraise
    raise value.with_traceback(tb)
  File "/usr/local/lib/python3.7/site-packages/django/core/handlers/exception.py", line 34, in inner
    response = get_response(request)
  File "/usr/local/lib/python3.7/site-packages/django/core/handlers/base.py", line 126, in _get_response
    response = self.process_exception_by_middleware(e, request)
  File "/usr/local/lib/python3.7/site-packages/django/core/handlers/base.py", line 124, in _get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "/usr/local/lib/python3.7/site-packages/django/views/decorators/http.py", line 40, in inner
    return func(request, *args, **kwargs)
  File "/usr/local/lib/python3.7/site-packages/django/views/decorators/csrf.py", line 54, in wrapped_view
    return view_func(*args, **kwargs)
  File "/usr/local/lib/python3.7/site-packages/ratelimit/decorators.py", line 27, in _wrapped
    increment=True)
  File "/usr/local/lib/python3.7/site-packages/ratelimit/utils.py", line 129, in is_ratelimited
    limited = usage.get('count') > usage.get('limit')
TypeError: '>' not supported between instances of 'NoneType' and 'int'
DEBUG:urllib3.connectionpool:Starting new HTTPS connection (1): api.github.com:443

i think we might have to pull the latest master in, because this is not a prob on the latest master

@pinkiebell
Copy link
Contributor Author

hmm i get this exception from sync/web3 when i try to post a new bounty

Traceback (most recent call last):
  File "/usr/local/lib/python3.7/site-packages/django/contrib/staticfiles/handlers.py", line 65, in __call__
    return self.application(environ, start_response)
  File "/usr/local/lib/python3.7/site-packages/django/core/handlers/wsgi.py", line 142, in __call__
    response = self.get_response(request)
  File "/usr/local/lib/python3.7/site-packages/django/core/handlers/base.py", line 78, in get_response
    response = self._middleware_chain(request)
  File "/usr/local/lib/python3.7/site-packages/django/core/handlers/exception.py", line 36, in inner
    response = response_for_exception(request, exc)
  File "/usr/local/lib/python3.7/site-packages/django/core/handlers/exception.py", line 90, in response_for_exception
    response = handle_uncaught_exception(request, get_resolver(get_urlconf()), sys.exc_info())
  File "/usr/local/lib/python3.7/site-packages/django/core/handlers/exception.py", line 125, in handle_uncaught_exception
    return debug.technical_500_response(request, *exc_info)
  File "/usr/local/lib/python3.7/site-packages/django_extensions/management/technical_response.py", line 37, in null_technical_500_response
    six.reraise(exc_type, exc_value, tb)
  File "/usr/local/lib/python3.7/site-packages/six.py", line 692, in reraise
    raise value.with_traceback(tb)
  File "/usr/local/lib/python3.7/site-packages/django/core/handlers/exception.py", line 34, in inner
    response = get_response(request)
  File "/usr/local/lib/python3.7/site-packages/django/core/handlers/base.py", line 126, in _get_response
    response = self.process_exception_by_middleware(e, request)
  File "/usr/local/lib/python3.7/site-packages/django/core/handlers/base.py", line 124, in _get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "/usr/local/lib/python3.7/site-packages/django/views/decorators/http.py", line 40, in inner
    return func(request, *args, **kwargs)
  File "/usr/local/lib/python3.7/site-packages/django/views/decorators/csrf.py", line 54, in wrapped_view
    return view_func(*args, **kwargs)
  File "/usr/local/lib/python3.7/site-packages/ratelimit/decorators.py", line 27, in _wrapped
    increment=True)
  File "/usr/local/lib/python3.7/site-packages/ratelimit/utils.py", line 129, in is_ratelimited
    limited = usage.get('count') > usage.get('limit')
TypeError: '>' not supported between instances of 'NoneType' and 'int'
DEBUG:urllib3.connectionpool:Starting new HTTPS connection (1): api.github.com:443

i think we might have to pull the latest master in, because this is not a prob on the latest master

Yes, looks like a django middleware problem 🤔

@pinkiebell pinkiebell closed this Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend This needs frontend expertise.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

migrate gitcoin from web3js 0.2 to 1.0
5 participants