Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate gitcoin from web3js 0.2 to 1.0 #2370

Closed
owocki opened this issue Oct 6, 2018 · 39 comments
Closed

migrate gitcoin from web3js 0.2 to 1.0 #2370

owocki opened this issue Oct 6, 2018 · 39 comments
Assignees
@owocki @spm32
Labels
enhancement This is a feature to be enhanced or improved.

Comments

@owocki
Copy link
Contributor

owocki commented Oct 6, 2018

the objective of this ticket its to migrate gitcoin from web3js 0.2 to 1.0

i've started a base branch at 13bc312 which you can use.

success criteria:

  • repo is upgraded to web3js 1.0
  • all references to web3.eth.coinbase updated
  • BOUNTIES: a funder can post a new bounty
  • BOUNTIES: user can fulfill a bounty
  • BOUNTIES: funder can increase payout
  • BOUNTIES: funder can accept a fulfillment (basic payout)
  • BOUNTIES: advanced payout works
  • TIPS: a user can post a new tip
  • TIPS: a user can receive a tip
  • ENS: a user can register an ENS subdomain at /ens
  • FAUCET: User can submit a new faucet page
  • FAUCET: admin can fund a faucet distribution.
  • REQUESTS: User can submit a new requests request

replaces #2369
@gitcoinbot
Copy link
Member

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This issue now has a funding of 0.5 ETH (112.72 USD @ $225.44/ETH) attached to it.

@owocki
Copy link
Contributor Author

owocki commented Oct 9, 2018

@usmanmuhd are you working on this? any updates?

@usmanmuhd
Copy link
Contributor

@owocki I will open WIP PR in just a while.

@usmanmuhd usmanmuhd mentioned this issue Oct 9, 2018
Closed
13 tasks
@gitcoinbot
Copy link
Member

@usmanmuhd Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • warning (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link
Member

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

@usmanmuhd due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

  • warning (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@usmanmuhd
Copy link
Contributor

Working on this, will push in changes tomorrow.

@owocki
Copy link
Contributor Author

owocki commented Oct 19, 2018

@usmanmuhd any update

@usmanmuhd
Copy link
Contributor

@owocki I had a few doubts, I guess they are addressed now. Will make the required changes and push in.

@rmshea
Copy link
Contributor

rmshea commented Oct 24, 2018

@usmanmuhd Ryan from Gitcoin checking in here. Do you have any questions? I didn't see a PR from you 😄 Let me know if you need anything with this issue 🔨

@usmanmuhd
Copy link
Contributor

@ryan-shea I have a WIP PR open. Had to turn in a few assignments. Hopefully this should be resolved by this weekend.

@usmanmuhd
Copy link
Contributor

Just informing that I will continue working on this once #2548 is merged. I guess we need to change most of the existing js to work in an async fashion.

@gitcoinbot
Copy link
Member

@usmanmuhd Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • warning (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link
Member

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

@usmanmuhd due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

  • warning (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@owocki
Copy link
Contributor Author

owocki commented Nov 3, 2018

I guess we need to change most of the existing js to work in an async fashion.

why?

@usmanmuhd
Copy link
Contributor

Most of the functions in 1.0 return promises. This is leading to a lot of errors here and there. I will do this once I finish eip1102.

@gitcoinbot
Copy link
Member

@usmanmuhd Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • warning (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@owocki
Copy link
Contributor Author

owocki commented Nov 6, 2018

Most of the functions in 1.0 return promises. This is leading to a lot of errors here and there. I will do this once I finish eip1102.

I'm not sure how we're going to do this given we don't have a JS build pipeline for Gitcoin.

@rmshea
Copy link
Contributor

rmshea commented Nov 8, 2018

Hey @owocki, snoozed the bot on this one. Are you going to open up the bounty to other hunters as well?

@usmanmuhd
Copy link
Contributor

I'm not sure how we're going to do this given we don't have a JS build pipeline for Gitcoin.

Do you mean for testing the patches?

@owocki
Copy link
Contributor Author

owocki commented Nov 8, 2018 •
edited
Loading

Hey @owocki, snoozed the bot on this one. Are you going to open up the bounty to other hunters as well?

I think that @usmanmuhd is still working on this right?

Do you mean for testing the patches?

Oh I had thought that not all browseres support async/await -- so we needed to have a npm build pipeline.. Perhaps I was wrong EDIT: isnt this called ES6?

@usmanmuhd
Copy link
Contributor

Yeah, it's called ES6. I guess almost everyone supports it except IE 😛.

@owocki
Copy link
Contributor Author

owocki commented Nov 8, 2018

one thing we talked about doing on the internal team call today @SaptakS @mbeacom @thelostone-mc was just not supporting very old IE browsers..

@gitcoinbot
Copy link
Member

@usmanmuhd Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@pinkiebell
Copy link
Contributor

What's the status on this one?
I and others hit errors because properties web3.eth.coinbase = null but the async web3.eth.getCoinbase works.

@owocki
Can we up this to high prio?

@usmanmuhd
Copy link
Contributor

I'll do this now. Need a rebase so that I can get kudos and the other changes on.

@usmanmuhd
Copy link
Contributor

I am currently very busy with assessments so not being able to do this. I will stop work so that it will open up to other people. I hope that my work done till now will help the next bounty hunter.

@gitcoinbot
Copy link
Member

💰 A crowdfund contribution worth 0.50000 ETH (53.85 USD @ $107.7/ETH) has been attached to this funded issue from @ceresstation.💰

Want to chip in also? Add your own contribution here.

@gitcoinbot
Copy link
Member

gitcoinbot commented Nov 28, 2018 •
edited
Loading

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work has been started.

These users each claimed they can complete the work by 3 months, 3 weeks ago.
Please review their action plans below:

1) pinkiebell has started work.

I will submit a pull request before weekend :)

Learn more on the Gitcoin Issue Details page.

@pinkiebell pinkiebell mentioned this issue Nov 29, 2018
Closed
14 tasks
@pinkiebell
Copy link
Contributor

So, I need someone to test kudos :)
It seems syncing kudos easily locally is still on the roadmap 🤣

@owocki
Copy link
Contributor Author

owocki commented Nov 29, 2018

theres some docs on how to get local kudos minted over at https://github.com/gitcoinco/web/blob/master/docs/KUDOS.md#how-do-i-gettest-kudos-on-my-local-rpc-node

@gitcoinbot
Copy link
Member

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work for 0.5 ETH (72.98 USD @ $145.96/ETH) has been submitted by:

  1. @pinkiebell

@owocki please take a look at the submitted work:

@rmshea
Copy link
Contributor

rmshea commented Jan 15, 2019

@owocki looks like this one is ready to be reviewed :)

@owocki
Copy link
Contributor Author

owocki commented Jan 16, 2019

thanks.. looking now

@rmshea
Copy link
Contributor

rmshea commented Jan 30, 2019

@owocki any thoughts here?

@owocki
Copy link
Contributor Author

owocki commented Jan 30, 2019

i agree it needs to be reviewed / regression tested by the core team

@spm32
Copy link
Collaborator

spm32 commented Apr 10, 2019

@owocki any updates on this one?

@owocki
Copy link
Contributor Author

owocki commented Apr 10, 2019

Pr still needs review; I'd suggest getting with product / engineering to set aside time to cleanout the PR backlog (includign this one)

@kuhnchris
Copy link
Contributor

@owocki @ceresstation can we still check this out or shall we kill it? Funds for @pinkiebell are also still floating around. Thanks

@kuhnchris kuhnchris added the enhancement This is a feature to be enhanced or improved. label Aug 25, 2019
@gitcoinbot
Copy link
Member

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

The funding of 0.5 ETH (91.27 USD @ $182.55/ETH) (plus a crowdfund of 0.5 ETH worth 91.27385535 USD) attached to this issue has been approved & issued to @pinkiebell.

Thanks to @ceresstation for their crowdfunded contributions to this bounty.

@misbahqadri misbahqadri mentioned this issue Mar 14, 2023
Open
This was referenced Mar 31, 2023
Open
Open
@snyk-bot snyk-bot mentioned this issue Apr 11, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@owocki owocki

@spm32 spm32

Labels
enhancement This is a feature to be enhanced or improved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Web3/1.0
8 participants
@owocki @kuhnchris @thelostone-mc @rmshea @spm32 @usmanmuhd @gitcoinbot @pinkiebell