Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile visuals #2766

Merged
merged 8 commits into from
Nov 13, 2018
Merged

Profile visuals #2766

merged 8 commits into from
Nov 13, 2018

Conversation

octavioamu
Copy link
Contributor

@octavioamu octavioamu commented Nov 12, 2018

Description

image
image

Checklist
  • linter status: 100% pass
  • changes don't break existing behavior
  • commit message follows commit guidelines
Affected core subsystem(s)
Testing
Refers/Fixes

Fixes: #2587 #2633

@codecov
Copy link

codecov bot commented Nov 12, 2018

Codecov Report

Merging #2766 into master will increase coverage by 1.85%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2766      +/-   ##
==========================================
+ Coverage   28.89%   30.75%   +1.85%     
==========================================
  Files         163      163              
  Lines       13080    13816     +736     
  Branches     1753     1945     +192     
==========================================
+ Hits         3780     4249     +469     
- Misses       9193     9407     +214     
- Partials      107      160      +53
Impacted Files Coverage Δ
app/dashboard/ios.py 20.89% <0%> (-56.89%) ⬇️
app/app/urls.py 82% <0%> (-4.96%) ⬇️
app/avatar/admin.py 67.34% <0%> (-1.89%) ⬇️
app/dashboard/gas_views.py 20.3% <0%> (-1.82%) ⬇️
app/avatar/utils.py 17.05% <0%> (-1.39%) ⬇️
app/dashboard/helpers.py 16.44% <0%> (-0.55%) ⬇️
app/avatar/models.py 26.01% <0%> (-0.31%) ⬇️
app/dashboard/views.py 12.83% <0%> (-0.05%) ⬇️
app/bounty_requests/admin.py 100% <0%> (ø) ⬆️
app/retail/management/commands/warm_cache.py 0% <0%> (ø) ⬆️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56405d6...1afc7d7. Read the comment docs.

@octavioamu octavioamu changed the title [WIP] Profile visuals Profile visuals Nov 12, 2018
Copy link
Member

@thelostone-mc thelostone-mc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@octavioamu change looks good ! just left a few comments ^_^

app/dashboard/templates/profiles/profile.html Outdated Show resolved Hide resolved
app/kudos/templates/shared/kudos_card_hover_content.html Outdated Show resolved Hide resolved
app/kudos/templates/shared/kudos_card_hover_content.html Outdated Show resolved Hide resolved
app/kudos/templates/shared/kudos_card_hover_content.html Outdated Show resolved Hide resolved
app/kudos/templates/shared/kudos_card_profile.html Outdated Show resolved Hide resolved
@octavioamu
Copy link
Contributor Author

@thelostone-mc @mbeacom Thanks for the review, all changes applied we are good to merge!!

Copy link
Contributor

@owocki owocki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@thelostone-mc thelostone-mc merged commit 2625644 into master Nov 13, 2018
@thelostone-mc thelostone-mc deleted the profile-visuals branch November 13, 2018 05:42
@thelostone-mc
Copy link
Member

thelostone-mc commented Nov 13, 2018

@octavioamu YAY it looks sweeet ^_^ \m/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants