-
-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
if someone has more than one of the same kudos, it should 'stack' on the profile to save space #2633
Comments
From @jasonrhaas on September 20, 2018 20:0 @octavioamu How hard do you think this one is? I've already had a scenario where this would super nice to have. |
Technically is a fun thing to do. But I had commented in slack the problem is about the public comments, in the example comments are separated, here we need to be able to read comments behind each kudos, so we can group kudos images but not the comments. We need an UX solution for that. |
another problem of grouping is we need to change also the pagination behavior to group it together and not in diff pages. |
@owocki @PixelantDesign is this v1 ? |
From @jasonrhaas on September 29, 2018 16:44 The good news is that since its purely a front-end effect, its an easy change to make in the future without affecting any core functionality. Might have to do something fancy like a flyout or modal, because there might be information that the user wants to see on each Kudos, like the comments for example. |
From @owocki on October 1, 2018 23:51 i dont feel super strongly about it being v1. if its an easy lift (less than an hour or two), and we have time.. then its fine to include it |
these look really good! |
From @owocki on September 20, 2018 18:15
like how uber does it
Copied from original issue: gitcoinco/gitcoin-erc721#91
The text was updated successfully, but these errors were encountered: