Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

if someone has more than one of the same kudos, it should 'stack' on the profile to save space #2633

Closed
octavioamu opened this issue Oct 31, 2018 · 8 comments
Assignees
Labels
enhancement This is a feature to be enhanced or improved. Gitcoin Kudos Gitcoin Kudos

Comments

@octavioamu
Copy link
Contributor

From @owocki on September 20, 2018 18:15

like how uber does it
image_from_ios

Copied from original issue: gitcoinco/gitcoin-erc721#91

@octavioamu octavioamu self-assigned this Oct 31, 2018
@octavioamu
Copy link
Contributor Author

From @jasonrhaas on September 20, 2018 20:0

@octavioamu How hard do you think this one is? I've already had a scenario where this would super nice to have.

image

@octavioamu
Copy link
Contributor Author

Technically is a fun thing to do. But I had commented in slack the problem is about the public comments, in the example comments are separated, here we need to be able to read comments behind each kudos, so we can group kudos images but not the comments. We need an UX solution for that.

@octavioamu
Copy link
Contributor Author

another problem of grouping is we need to change also the pagination behavior to group it together and not in diff pages.

@octavioamu
Copy link
Contributor Author

@owocki @PixelantDesign is this v1 ?

@octavioamu
Copy link
Contributor Author

From @jasonrhaas on September 29, 2018 16:44

The good news is that since its purely a front-end effect, its an easy change to make in the future without affecting any core functionality.

Might have to do something fancy like a flyout or modal, because there might be information that the user wants to see on each Kudos, like the comments for example.

@octavioamu
Copy link
Contributor Author

From @owocki on October 1, 2018 23:51

i dont feel super strongly about it being v1. if its an easy lift (less than an hour or two), and we have time.. then its fine to include it

@PixelantDesign
Copy link
Contributor

screen shot 2018-11-08 at 3 56 54 pm

@owocki
Copy link
Contributor

owocki commented Nov 8, 2018

these look really good!

@octavioamu octavioamu mentioned this issue Nov 12, 2018
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This is a feature to be enhanced or improved. Gitcoin Kudos Gitcoin Kudos
Projects
None yet
Development

No branches or pull requests

4 participants