Skip to content
This repository has been archived by the owner on Jan 26, 2023. It is now read-only.

if someone has more than one of the same kudos, it should 'stack' on the profile to save space #91

Closed
owocki opened this issue Sep 20, 2018 · 7 comments
Assignees

Comments

@owocki
Copy link
Contributor

owocki commented Sep 20, 2018

like how uber does it
image_from_ios

@jasonrhaas jasonrhaas changed the title if someone has more than one of the same kudos, it should 'stack' on the profile to save space\ if someone has more than one of the same kudos, it should 'stack' on the profile to save space Sep 20, 2018
@jasonrhaas
Copy link
Collaborator

@octavioamu How hard do you think this one is? I've already had a scenario where this would super nice to have.

image

@octavioamu
Copy link
Collaborator

Technically is a fun thing to do. But I had commented in slack the problem is about the public comments, in the example comments are separated, here we need to be able to read comments behind each kudos, so we can group kudos images but not the comments. We need an UX solution for that.

@octavioamu
Copy link
Collaborator

another problem of grouping is we need to change also the pagination behavior to group it together and not in diff pages.

@octavioamu
Copy link
Collaborator

@owocki @PixelantDesign is this v1 ?

@jasonrhaas
Copy link
Collaborator

jasonrhaas commented Sep 29, 2018

The good news is that since its purely a front-end effect, its an easy change to make in the future without affecting any core functionality.

Might have to do something fancy like a flyout or modal, because there might be information that the user wants to see on each Kudos, like the comments for example.

@owocki
Copy link
Contributor Author

owocki commented Oct 1, 2018

i dont feel super strongly about it being v1. if its an easy lift (less than an hour or two), and we have time.. then its fine to include it

@octavioamu
Copy link
Collaborator

This issue was moved to gitcoinco/web#2633

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants