Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove range retry attempt from mint_all_kudos #2659

Merged
merged 2 commits into from
Nov 1, 2018
Merged

Conversation

mbeacom
Copy link
Contributor

@mbeacom mbeacom commented Oct 31, 2018

Description

The goal of this PR is to eliminate the retry attempts when minting a kudos fails in mint_all_kudos

Checklist
  • linter status: 100% pass
  • changes don't break existing behavior
  • commit message follows commit guidelines
Affected core subsystem(s)

kudos

Testing

Locally

Refers/Fixes

Fix #2654

@mbeacom mbeacom added backend This needs backend expertise. Gitcoin Kudos Gitcoin Kudos labels Oct 31, 2018
@mbeacom mbeacom self-assigned this Oct 31, 2018
@codecov
Copy link

codecov bot commented Oct 31, 2018

Codecov Report

Merging #2659 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2659      +/-   ##
==========================================
- Coverage   29.94%   29.89%   -0.05%     
==========================================
  Files         162      162              
  Lines       12958    12958              
  Branches     1738     1738              
==========================================
- Hits         3880     3874       -6     
- Misses       8954     8960       +6     
  Partials      124      124
Impacted Files Coverage Δ
app/dashboard/embed.py 28.16% <0%> (-3.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6ec332...c7307a8. Read the comment docs.

@mbeacom mbeacom merged commit f2ba76d into master Nov 1, 2018
octavioamu pushed a commit that referenced this pull request Nov 2, 2018
* Fix #2654 - Remove range retry attempt from mint_all_kudos

* Remove unused time import
@thelostone-mc thelostone-mc deleted the fix-2654-mintrange branch December 28, 2018 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend This needs backend expertise. Gitcoin Kudos Gitcoin Kudos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant