Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove range retry for minting kudos #2654

Closed
mbeacom opened this issue Oct 31, 2018 · 0 comments
Closed

Remove range retry for minting kudos #2654

mbeacom opened this issue Oct 31, 2018 · 0 comments
Assignees
@mbeacom
Labels
backend This needs backend expertise. enhancement This is a feature to be enhanced or improved. Gitcoin Kudos Gitcoin Kudos

Comments

@mbeacom
Copy link
Contributor

mbeacom commented Oct 31, 2018

When executing mint_all_kudos we shouldn't retry using for __ in range(1, 4)
Adjust the output to elaborate on the failure and remove the retry based on range.
@mbeacom mbeacom added enhancement This is a feature to be enhanced or improved. backend This needs backend expertise. Gitcoin Kudos Gitcoin Kudos labels Oct 31, 2018
@mbeacom mbeacom self-assigned this Oct 31, 2018
mbeacom added a commit that referenced this issue Oct 31, 2018
@mbeacom
Fix #2654 - Remove range retry attempt from mint_all_kudos
a878e55
@mbeacom mbeacom mentioned this issue Oct 31, 2018
Merged
3 tasks
mbeacom pushed a commit that referenced this issue Nov 1, 2018
Remove range retry attempt from mint_all_kudos (#2659)
f2ba76d 
* Fix #2654 - Remove range retry attempt from mint_all_kudos

* Remove unused time import
octavioamu pushed a commit that referenced this issue Nov 2, 2018
@octavioamu
Remove range retry attempt from mint_all_kudos (#2659)
3a4d2d8 
* Fix #2654 - Remove range retry attempt from mint_all_kudos

* Remove unused time import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mbeacom mbeacom

Labels
backend This needs backend expertise. enhancement This is a feature to be enhanced or improved. Gitcoin Kudos Gitcoin Kudos
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mbeacom