Kudos v1 #2492

jasonrhaas · 2018-10-18T22:00:37Z

Description

Kudos!

Checklist

linter status: 100% pass
changes don't break existing behavior
commit message follows commit guidelines

Affected core subsystem(s)

ui
database
new blockchain contract

Testing

To run this locally you must have the solidity contract code locally on your machine. It should be at the same directory level as this repo. The repository is called gitcoin-erc721. After you have cloned that repo, follow these steps inside this repo:

git checkout kudos-v1
export TEST_MNEMONIC="Your test mnemonic"
docker-compose pull to pull in all the latest images
docker-compose build --force-rm to force a fresh build of the web docker container
./fresh_start to remove old docker volumes, spin up fresh instances, deploy the kudos contract locally, and finally mint all the kudos. Kudos will be minted to the first account in the wallet. Contact the Gitcoin core team to get the test keys for Rinkeby.
Navigate to http://localhost:8000/kudos and be sure to use the "Private Network" setting in MetaMask.

Refers/Fixes

Fix dupes

New kudos

See gitcoinco/gitcoin-erc721#162

Updates to handle the latest Kudos contract changes

Fixes

WIP Kudos integrate

Deploy latest

Syncing this way still sucks though

mbeacom · 2018-10-26T14:49:10Z

app/app/context.py

@@ -75,7 +76,12 @@ def insert_settings(request):
            username__iexact=context['github_handle'],
            web3_type='v3',
        ).exclude(txid='')
+        context['unclaimed_kudos'] = KudosTransfer.objects.filter(
+            receive_txid='', username__iexact="@" + context['github_handle'], web3_type='v3',


Can we update this model to directly relate to Profile?

@jasonrhaas

mbeacom · 2018-10-26T14:50:58Z

app/assets/onepager/js/receive.js

@@ -25,7 +25,7 @@ window.onload = function() {
    }
    ipfs.catText(document.ipfs_key_to_secret, function(err, key2) {
      if (err) {
-        _alert('could not reach IPFS.  please try again later.', 'error');
+        _alert('Could not reach IPFS.  please try again later.', 'error');


app/assets/v2/css/kudos/select2.bootstrap4.scss

mbeacom · 2018-10-26T15:00:38Z

app/assets/v2/js/eth-price.js

@@ -0,0 +1,33 @@
+/**
+ * Transform eth to usd


mbeacom · 2018-10-26T15:04:08Z

app/assets/v2/js/pages/kudos_details.js

+
+var rotate_kudos_msg = function() {
+  var messages = [
+    [ 'Buy Me!', 'I\'m looking for a good home.' ],


@octavioamu @jasonrhaas Does this apply to all of the copy? Like the alert text for cloning errors?

mbeacom · 2018-10-26T15:54:29Z

app/dashboard/views.py

+            owner_address=to_checksum_address(context['preferred_payout_address']),
+            contract__network=settings.KUDOS_NETWORK
+        ).order_by(order_by)
+        sent_kudos = Token.objects.filter(


We should select_related on the 'kudos_transfer', 'contract' since we're filtering on values from it here.

mbeacom · 2018-10-26T15:54:38Z

app/dashboard/views.py

+    if context['preferred_payout_address']:
+        owned_kudos = Token.objects.filter(
+            owner_address=to_checksum_address(context['preferred_payout_address']),
+            contract__network=settings.KUDOS_NETWORK


We should select_related on the 'contract' since we're filtering on values from it here.

mbeacom · 2018-10-26T15:54:51Z

app/dashboard/views.py

+        # Send kudos data when new preferred address
+        address = request.POST.get('address')
+        context['kudos'] = Token.objects.filter(owner_address=to_checksum_address(address)).order_by(order_by)
+        context['sent_kudos'] = Token.objects.filter(kudos_transfer__from_address=to_checksum_address(address)).order_by(order_by)


We should select_related on the 'kudos_transfer' since we're filtering on values from it here.

mbeacom · 2018-10-26T15:55:43Z

app/dashboard/views.py

+    datarequest = request.POST.get('request')
+    order_by = request.GET.get('order_by', '-modified_on')
+    # use Django’s pagination
+    # https://docs.djangoproject.com/en/dev/topics/pagination/


Can we omit these comments? Also, should we use paginator.get_page(page) vs the manual handling of emptypage/integer/etc ?

We can evaluate, I don't really know if with get_page we can do the same, I have seen get_page looks simpler. Right now each request is controlled by an ajax request from front end and then is returned the html cards json that a way (not nearly the best I know) to avoid redo all the front end logic two times (when page loads and when load more is clicked) In that way we are reusing the django template (quicker) instead of fill html with js. I think in a V2 we should go to a full ajax > json way and then change to get_page

So I was taking a look go get_page and I think doesn't make change to wait to change, code gets more simpler, making the changes here!

mbeacom · 2018-10-26T15:55:50Z

app/dashboard/views.py

+    if datarequest == 'mykudos':
+        context['kudos'] = Token.objects.filter(owner_address=to_checksum_address(address)).order_by(order_by)
+        paginator = Paginator(context['kudos'], results_per_page)
+    else :


The issue was that is was using the incorrect tokenId. It was using kudos_token.id (pk) instead of the kudos_token.token_id (contract token id).

… relations

…en QAed and looks good

mbeacom

yolo 🎲

octavioamu · 2018-10-27T20:48:28Z

Great job @mbeacom

jasonrhaas and others added 30 commits October 8, 2018 15:12

Don't show unclonable Kudos in marketplace

3e71b72

Merge pull request gitcoinco#33 from mbeacom/fix-dupes

9a599fc

Fix dupes

Add new kudos

feacbe5

Don't restrict kudos minting at all

e97a12e

Merge pull request gitcoinco#35 from mbeacom/new-kudos

5e13c12

New kudos

Updates to handle the latest Kudos contract changes

f580549

See gitcoinco/gitcoin-erc721#162

Merge pull request gitcoinco#36 from mbeacom/clone-fee

cd7c567

Updates to handle the latest Kudos contract changes

Fix IPFS CORs problem again

718ccba

Update how rarity gets set

7ef497a

kudos.yaml now has tags as an array of strings

274cc74

Add new kudos images

89b154e

update rinkeby address for abi.js

dbeabe4

new rinkeby contract address

e6cea39

update crontab

edf50fb

Merge pull request gitcoinco#34 from mbeacom/fixes

6d19de6

Fixes

Merge pull request gitcoinco#32 from mbeacom/kudos-integrate

766f9bb

WIP Kudos integrate

Merge branch 'kudos-v1' into deploy-latest

9651a83

Merge pull request gitcoinco#37 from mbeacom/deploy-latest

09370f0

Deploy latest

Fix Kudos name not showing up on receive page

67653c1

fix js bug in kudos_send

96ac80e

prompts

433376b

kudos levitation demo

0f3fdf3

refactor

d6cbe6e

kudos goodies

b7fe1fa

Add kudos email preview

5fcc086

change logo

ab15065

change detail kudos styles

cf9735f

change var kudos

009249c

Partials are fun

820a7c4

no more levitate

6eb6b0d

octavioamu and others added 10 commits October 25, 2018 21:44

update text

7c44534

Change rarity labels

cea19ec

add generation

1c86485

Add new kudos assets

6b49db3

New deployment to rinkeby

c07800d

Update method id's for block listener

29fb069

Syncing this way still sucks though

Handle case where start_id might not be valid

e99937b

FIx blue box overlap values

c0af7e1

Sync Gen0 token when cloned

87e14f9

Fix kudos detail numbers

edfbee6

mbeacom reviewed Oct 26, 2018

View reviewed changes

jasonrhaas and others added 16 commits October 26, 2018 12:09

Fix Kudos Indirect Send

aa7a0ee

The issue was that is was using the incorrect tokenId. It was using kudos_token.id (pk) instead of the kudos_token.token_id (contract token id).

add gold line

23cb332

fix sent cards data

3b65b3d

clean

a281f78

fix pagination and change method

c6a33ab

remove white space

98fd05a

Update for latest Rinkeby Contract

7624be1

FIx typo

c2c55bd

Update mainnet contract address

9458d75

Add additional gas_price_gwei option

c28901c

Make gas price optional

ee4fb35

Fix sent kudos on profile, adjust some logic and DRY it up a bit

78b42d7

Adjust profile kudos queries to use both pref payout addy and profile…

29e8d63

… relations

Update kudos detail route to use kudos_id

033350c

hide kudos stuff until its been QAed... revert this when kudos has be…

d24a727

…en QAed and looks good

Squash kudos migrations

46fe530

mbeacom approved these changes Oct 27, 2018

View reviewed changes

mbeacom merged commit bb911ee into gitcoinco:master Oct 27, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Kudos v1 #2492

Kudos v1 #2492

jasonrhaas commented Oct 18, 2018

mbeacom Oct 26, 2018

octavioamu Oct 26, 2018

mbeacom Oct 26, 2018

mbeacom Oct 26, 2018

mbeacom Oct 26, 2018

mbeacom Oct 26, 2018

mbeacom Oct 26, 2018

mbeacom Oct 26, 2018

mbeacom Oct 26, 2018

octavioamu Oct 26, 2018

octavioamu Oct 26, 2018

mbeacom Oct 26, 2018

mbeacom left a comment

octavioamu commented Oct 27, 2018

Kudos v1 #2492

Kudos v1 #2492

Conversation

jasonrhaas commented Oct 18, 2018

Description

Checklist

Affected core subsystem(s)

Testing

Refers/Fixes

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mbeacom left a comment

Choose a reason for hiding this comment

octavioamu commented Oct 27, 2018