Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when accessing with Mist 0.9.2 #36

Closed
phal0r opened this issue Oct 23, 2017 · 2 comments
Closed

Error when accessing with Mist 0.9.2 #36

phal0r opened this issue Oct 23, 2017 · 2 comments
Labels
bug This is something that isn't working as intended. Gitcoin.co Gitcoin.co site

Comments

@phal0r
Copy link

phal0r commented Oct 23, 2017

When authorizing gitcoin.co with Mist I get the following errors:

Uncaught Error: TrackJS Caught: Cannot read property 'coinbase' of undefined
at get_search_URI (dashboard.js:64)
Uncaught Error: TrackJS Caught: Cannot read property 'accounts' of undefined
 at shared.js:296

Gitcoin wants to access the eth object in web3, but it is undefined. This is due to the way web3 is provided. Mist offers a basic web3 object with the currentProvider set to Ethereum Provider.

According to the Ethereum wiki (https://github.com/ethereum/wiki/wiki/JavaScript-API) this is the recommended way to init web3:

if (typeof web3 !== 'undefined') {
  web3 = new Web3(web3.currentProvider);
} else {
  // set the provider you want from Web3.providers
  web3 = new Web3(new Web3.providers.HttpProvider("http://localhost:8545"));
}

I would expect gitcoin to include a packaged version of web3.js and instanciate it in the above mentioned way to support Mist.

@owocki owocki added the bug This is something that isn't working as intended. label Oct 23, 2017
@owocki
Copy link
Contributor

owocki commented Oct 23, 2017

i mostly use chrome / metamask. i need to add geth to the regression testing list.

@PixelantDesign
Copy link
Contributor

@mbeacom do we still need this issue?

owocki pushed a commit that referenced this issue Oct 10, 2018
Updates to handle the latest Kudos contract changes
@frankchen07 frankchen07 added the Gitcoin.co Gitcoin.co site label Nov 24, 2018
@kuhnchris kuhnchris added this to the Backlog > 1 Year - Relevance Check milestone Aug 1, 2019
@kuhnchris kuhnchris added the Web3 label Aug 1, 2019
zoek1 pushed a commit to zoek1/web-1 that referenced this issue Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This is something that isn't working as intended. Gitcoin.co Gitcoin.co site
Projects
None yet
Development

No branches or pull requests

6 participants