[WIP] Fixes: https://github.com/gitcoinco/web/issues/1855 #2371

saketbairoliya2 · 2018-10-07T09:58:05Z

Description

This PR will handle creation of Bounty directly when a request is submitted.

Checklist

linter status: 100% pass
changes don't break existing behavior
commit message follows commit guidelines

Affected core subsystem(s)

Testing

Refers/Fixes

Refs: #1855

…ate Bounty with flag - requested.

stickler-ci · 2018-10-07T09:58:16Z

app/bounty_requests/models.py

@@ -22,8 +22,14 @@
 from django.core.validators import MinValueValidator
 from django.db import models

+from datetime import date, datetime, timedelta


F401 'datetime.date' imported but unused

stickler-ci · 2018-10-07T09:58:16Z

app/bounty_requests/models.py

+
+    def to_bounty(self, network=None):
+        """Creates a bounty with project status as requested. """
+        print ('self value is {} - {} - Type {}'.format(self.github_url, self.amount, type(self.amount)))


E211 whitespace before '('

stickler-ci · 2018-10-07T09:58:16Z

app/bounty_requests/models.py

+    def to_bounty(self, network=None):
+        """Creates a bounty with project status as requested. """
+        print ('self value is {} - {} - Type {}'.format(self.github_url, self.amount, type(self.amount)))
+        new_bounty = Bounty.objects.create(


F841 local variable 'new_bounty' is assigned to but never used

stickler-ci · 2018-10-07T09:58:16Z

app/bounty_requests/models.py

+            value_true=float(self.amount),
+            network=network,
+            web3_created=datetime.now(tz=pytz.UTC),
+            expires_date=datetime.now(tz=pytz.UTC) + timedelta(days=90), # Request expire in 3 months. 


E261 at least two spaces before inline comment
W291 trailing whitespace

stickler-ci · 2018-10-07T09:58:16Z

app/bounty_requests/models.py

+            network=network,
+            web3_created=datetime.now(tz=pytz.UTC),
+            expires_date=datetime.now(tz=pytz.UTC) + timedelta(days=90), # Request expire in 3 months. 
+            is_open=False, # By default mark this as False as this will require fund. 


E261 at least two spaces before inline comment
W291 trailing whitespace

stickler-ci · 2018-10-07T09:58:17Z

app/bounty_requests/models.py

+            expires_date=datetime.now(tz=pytz.UTC) + timedelta(days=90), # Request expire in 3 months. 
+            is_open=False, # By default mark this as False as this will require fund. 
+            raw_data={},
+            current_bounty=True # By default it would be marked as the current bounty. 


E261 at least two spaces before inline comment
W291 trailing whitespace

stickler-ci · 2018-10-07T09:58:17Z

app/bounty_requests/models.py

+            current_bounty=True # By default it would be marked as the current bounty. 
+        )
+
+        print ('Bounty is created. ')


E211 whitespace before '('

stickler-ci · 2018-10-07T09:58:17Z

app/dashboard/models.py

@@ -544,6 +545,8 @@ def status(self):
            if not self.is_open:
                if self.accepted:
                    return 'done'
+                elif self.idx_status=='requested':


E225 missing whitespace around operator

codecov · 2018-10-07T10:04:25Z

Codecov Report

Merging #2371 into master will increase coverage by 0.01%.
The diff coverage is 54.54%.

@@            Coverage Diff             @@
##           master    #2371      +/-   ##
==========================================
+ Coverage   29.47%   29.49%   +0.01%     
==========================================
  Files         146      146              
  Lines       11777    11787      +10     
  Branches     1599     1600       +1     
==========================================
+ Hits         3471     3476       +5     
- Misses       8188     8192       +4     
- Partials      118      119       +1

Impacted Files	Coverage Δ
app/bounty_requests/views.py	`36.36% <0%> (-2.35%)`	⬇️
app/dashboard/models.py	`52.71% <33.33%> (-0.08%)`	⬇️
app/bounty_requests/models.py	`92.85% <83.33%> (-2.6%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99a12e2...c520cbc. Read the comment docs.

mbeacom · 2018-11-29T03:19:50Z

app/bounty_requests/models.py

@@ -64,3 +69,18 @@ class BountyRequest(SuperModel):
    def __str__(self):
        """Return the string representation of BountyRequest."""
        return f"{self.requested_by.username} / {self.created_on}"
+
+    def to_bounty(self, network=None):


Should we associate the bountyrequest with the bounty?

mbeacom · 2018-11-29T03:20:20Z

@saketbairoliya2 Is this still a WIP?

saketbairoliya2 · 2018-11-29T04:30:06Z

Yes, I'll try to finish it this week. Apologies for delay. kumar saket

…

On Thu, Oct 11, 2018, 5:14 PM Mark Beacom ***@***.*** wrote: ⭐️ PR built and available in a preview environment *gitcoinco-web-pr-2371* here <http://web.jx-gitcoinco-web-pr-2371.ci.gitcoin.co> — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#2371 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFrIAYHrdk6FYlpNZaUzPMItz0Qa0Oj_ks5ujy8GgaJpZM4XLxHk> .

octavioamu · 2018-11-29T15:32:19Z

In general is looking good but need a rebase with the current explorer changes, lot of things had changed in the explorer

octavioamu

Need rebase with master changes in explorer

kuhnchris · 2019-02-12T20:10:05Z

@saketbairoliya2 @octavioamu i rebased it over at #3734

thelostone-mc · 2019-06-22T14:32:11Z

Closing this out based on above comment ^

Fixes: gitcoinco#1855, Introduces a function in Bounty Request to cre…

6ba6c29

…ate Bounty with flag - requested.

stickler-ci reviewed Oct 7, 2018

View reviewed changes

Solving linting issues and removing comments.

c5bc9c8

Kumar Saket added 2 commits October 7, 2018 15:42

Removing commenst.

e4966a4

Adding sort order to libs.

c520cbc

mbeacom reviewed Nov 29, 2018

View reviewed changes

mbeacom changed the title ~~Fixes: https://github.com/gitcoinco/web/issues/1855 (WIP)~~ [WIP] Fixes: https://github.com/gitcoinco/web/issues/1855 Nov 29, 2018

mbeacom added frontend This needs frontend expertise. backend This needs backend expertise. wip Gitcoin Bounties Gitcoin Bounties labels Nov 29, 2018

mbeacom requested a review from a team November 29, 2018 03:21

octavioamu suggested changes Nov 29, 2018

View reviewed changes

thelostone-mc mentioned this pull request Nov 30, 2018

[Code] Gitcoin Requests #1033

Closed

PixelantDesign added the Green Team label Jan 9, 2019

kuhnchris mentioned this pull request Feb 12, 2019

Continuation of #2371, Gitcoin Requests [Backend] #1855 #3734

Closed

thelostone-mc closed this Jun 22, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] Fixes: https://github.com/gitcoinco/web/issues/1855 #2371

[WIP] Fixes: https://github.com/gitcoinco/web/issues/1855 #2371

saketbairoliya2 commented Oct 7, 2018 •

edited by octavioamu

Loading

stickler-ci Oct 7, 2018

stickler-ci Oct 7, 2018

stickler-ci Oct 7, 2018

stickler-ci Oct 7, 2018

stickler-ci Oct 7, 2018

stickler-ci Oct 7, 2018

stickler-ci Oct 7, 2018

stickler-ci Oct 7, 2018

codecov bot commented Oct 7, 2018 •

edited

Loading

mbeacom Nov 29, 2018

mbeacom commented Nov 29, 2018

saketbairoliya2 commented Nov 29, 2018 via email

octavioamu commented Nov 29, 2018 •

edited

Loading

octavioamu left a comment

kuhnchris commented Feb 12, 2019

thelostone-mc commented Jun 22, 2019

[WIP] Fixes: https://github.com/gitcoinco/web/issues/1855 #2371

[WIP] Fixes: https://github.com/gitcoinco/web/issues/1855 #2371

Conversation

saketbairoliya2 commented Oct 7, 2018 • edited by octavioamu Loading

Description

Checklist

Affected core subsystem(s)

Testing

Refers/Fixes

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Oct 7, 2018 • edited Loading

Codecov Report

Choose a reason for hiding this comment

mbeacom commented Nov 29, 2018

saketbairoliya2 commented Nov 29, 2018 via email

octavioamu commented Nov 29, 2018 • edited Loading

octavioamu left a comment

Choose a reason for hiding this comment

kuhnchris commented Feb 12, 2019

thelostone-mc commented Jun 22, 2019

saketbairoliya2 commented Oct 7, 2018 •

edited by octavioamu

Loading

codecov bot commented Oct 7, 2018 •

edited

Loading

octavioamu commented Nov 29, 2018 •

edited

Loading