9987 kill quadratic lands remove app #10138
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tim-schultz
requested review from
chibie,
gdixon,
nutrina and
thelostone-mc
as code owners
| @@ -770,9 +771,9 @@ | |||
| url(r'^blocknative', perftools.views.blocknative, name='blocknative'), | |||
|
|
|||
| # quadratic lands | |||
| path('quadraticlands/', include('quadraticlands.urls', namespace='quadraticlands')), | |||
| re_path(r'^quadraticlands/?', include('quadraticlands.urls', namespace='ql_catchall_')), | |||
| re_path(r'^quadraticland/?', include('quadraticlands.urls', namespace='ql_catchall')), | |||
There was a problem hiding this comment.
this is just a nightmare :P meh meh meh
gdixon
reviewed
Feb 16, 2022
| @@ -24,7 +24,6 @@ WORKDIR /usr/src | |||
| RUN apt-get update && apt-get install -y wget | |||
| RUN wget "https://dl.google.com/linux/direct/google-chrome-stable_current_amd64.deb" | |||
| RUN apt-get install -y $CHROME_DEPS | |||
| RUN dpkg -i google-chrome-stable_current_amd64.deb | |||
There was a problem hiding this comment.
Was this supposed to be dropped here?
There was a problem hiding this comment.
lol that fails on the m1 :P but should be a in a seperate PR anyways
|
@schultztimothy the other PR is rolled out ! When you're ready. -> we can update this PR and make sure only the new commits are present |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a follow up to #10137. It removes the remaining files and reference to quadratic lands
Refers/Fixes
fixes: #9987