Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

9987 kill quadratic lands w migrations #10137

Merged
merged 8 commits into from
Feb 17, 2022

Conversation

tim-schultz
Copy link
Contributor

@tim-schultz tim-schultz commented Feb 9, 2022

Description
As a Gitcoin user
I want to only see the decentralized version of the Quadratic Lands site
So that I am only seeing the correct, community-owned information

Acceptance Criteria
GIVEN that I am on gitcoin.co
WHEN I try to visit https://gitcoin.co/quadraticlands
THEN I am sent to http://decentralized.quadraticlands.com/

we no longer should be maintaining this portion of the site. it is now managed by the DAO per https://gitcoin.co/issue/gitcoinco/skunkworks/239/100026286

Refers/Fixes
fixes: #9987

According to https://techstream.org/Bits/Remove-App-From-Django-Project its best to follow this up with another PR that fully removes the app from the monorepo. Still pretty new to django so open to suggestions on this 😄

@tim-schultz tim-schultz marked this pull request as draft February 9, 2022 21:05
@tim-schultz tim-schultz marked this pull request as ready for review February 10, 2022 17:24
Copy link
Member

@thelostone-mc thelostone-mc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with this approach !
Left a comment on the migration update but otherwise LGTM

Copy link
Contributor

@ksolo ksolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small suggestion (non-blocker).

looks good!

app/app/views.py Outdated Show resolved Hide resolved
Copy link
Contributor

@gdixon gdixon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I've a left a comment about somewhere that might have been missed, but other than that, looking great! 🚀

@thelostone-mc thelostone-mc merged commit 212c45a into master Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kill centralized /quadraticlands and forward to DAO-owned page
4 participants